[PR #14509] [MERGED] fix: only trust codec_name for audio conversion #39122

New Issue

GiteaMirror · 2026-04-25T11:51:54-05:00

GiteaMirror commented

2026-04-25 11:51:54 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14509
Author: @r0mdau
Created: 5/29/2025
Status: ✅ Merged
Merged: 5/29/2025
Merged by: @tjbck

Base: dev ← Head: fix/audio-format

📝 Commits (3)

737dc77 Merge pull request #14390 from open-webui/dev
ba0088f Merge pull request #14441 from open-webui/dev
b12a493 fix: only trust codec_name for audio conversion

📊 Changes

1 file changed (+3 additions, -6 deletions)

View changed files

📝 backend/open_webui/routers/audio.py (+3 -6)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Some files have .wav extension with incompatible opus OpenAI codec. It is best to rely only on codec_name

Fixed

Fixed audio conversion relying only on detected audio code by medialibrary

Additional Information

When using the call function, I am using Chrome and OpenWebUI ends with .wav audio file extension with a opus codec name. I get a 400 error from OpenAI for incompatible audio format when using

gpt-4o-mini-transcribe
gpt-4o-transcribe

So in the audio.py file, the is_audio_conversion_required function returns false.

It is generally a bad practice to act on file extensions, when having good tools that can read files metadata, this is more reliable.

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14509 **Author:** [@r0mdau](https://github.com/r0mdau) **Created:** 5/29/2025 **Status:** ✅ Merged **Merged:** 5/29/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/audio-format` --- ### 📝 Commits (3) - [`737dc77`](https://github.com/open-webui/open-webui/commit/737dc7797ce5eb0f3dbe08bd1ab6778ea59f538e) Merge pull request #14390 from open-webui/dev - [`ba0088f`](https://github.com/open-webui/open-webui/commit/ba0088f39b7a093920b142a5172554686f24df60) Merge pull request #14441 from open-webui/dev - [`b12a493`](https://github.com/open-webui/open-webui/commit/b12a493fe5248d51ad755586e8a306d820ce9770) fix: only trust codec_name for audio conversion ### 📊 Changes **1 file changed** (+3 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/audio.py` (+3 -6) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Some files have `.wav` extension with incompatible `opus` OpenAI codec. It is best to rely only on codec_name ### Fixed - Fixed audio conversion relying only on detected audio code by medialibrary --- ### Additional Information When using the call function, I am using Chrome and OpenWebUI ends with `.wav` audio file extension with a `opus` codec name. I get a 400 error from OpenAI for incompatible audio format when using - gpt-4o-mini-transcribe - gpt-4o-transcribe So in the `audio.py` file, the `is_audio_conversion_required` function returns false. It is generally a bad practice to act on file extensions, when having good tools that can read files metadata, this is more reliable. ### Screenshots or Videos ![image](https://github.com/user-attachments/assets/903bbf3a-289b-4962-9c72-e616269b5f14) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:51:54 -05:00

GiteaMirror closed this issue

2026-04-25 11:51:55 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39122