[PR #14443] [CLOSED] fix: reasoning not done right before function calling. #39102

New Issue

GiteaMirror · 2026-04-25T11:50:34-05:00

GiteaMirror commented

2026-04-25 11:50:34 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14443
Author: @funnycups
Created: 5/28/2025
Status: ❌ Closed

Base: dev ← Head: main

📝 Commits (4)

9faa4c6 Merge pull request #14194 from open-webui/dev
b8e1621 Merge pull request #14364 from open-webui/dev
737dc77 Merge pull request #14390 from open-webui/dev
3510b3b Fix reasoning not done right before function calling.

📊 Changes

1 file changed (+9 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+9 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Currently, reasoning will not be marked done if model call tools right after reasoning and send no text message. This PR should fix it.

Fixed

Reasoning not done right before function calling.

Additional Information

There's still one reasoning problems I found in this discussion, but I currently have no clue how to solve it.

Screenshots or Videos

As shown in screenshots, reasoning is now marked down right before function calling.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14443 **Author:** [@funnycups](https://github.com/funnycups) **Created:** 5/28/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (4) - [`9faa4c6`](https://github.com/open-webui/open-webui/commit/9faa4c6a4cd8dd643cddb93dccb65c6609488a29) Merge pull request #14194 from open-webui/dev - [`b8e1621`](https://github.com/open-webui/open-webui/commit/b8e16211b9d207e91b7da0a2055a7a679c05b6ce) Merge pull request #14364 from open-webui/dev - [`737dc77`](https://github.com/open-webui/open-webui/commit/737dc7797ce5eb0f3dbe08bd1ab6778ea59f538e) Merge pull request #14390 from open-webui/dev - [`3510b3b`](https://github.com/open-webui/open-webui/commit/3510b3b4bda1c569bad2b292dd7b05d937ccae3b) Fix reasoning not done right before function calling. ### 📊 Changes **1 file changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+9 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Currently, reasoning will not be marked done if model call tools right after reasoning and send no text message. This PR should fix it. ### Fixed - Reasoning not done right before function calling. --- ### Additional Information - There's still one reasoning problems I found in [this discussion](https://github.com/open-webui/open-webui/discussions/14286), but I currently have no clue how to solve it. ### Screenshots or Videos As shown in screenshots, reasoning is now marked down right before function calling. ![image](https://github.com/user-attachments/assets/0873a249-112f-422b-953f-453e4de78c5f) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:50:34 -05:00

GiteaMirror closed this issue

2026-04-25 11:50:37 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39102