[PR #14427] [CLOSED] wip: Optimize get_all_models #39098

New Issue

GiteaMirror · 2026-04-25T11:50:26-05:00

GiteaMirror commented

2026-04-25 11:50:26 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14427
Author: @torisetxd
Created: 5/27/2025
Status: ❌ Closed

Base: dev ← Head: optimize-model-fetching-v2

📝 Commits (1)

dd70595 Add function to retrieve functions by IDs and optimize model fetching logic

📊 Changes

2 files changed (+131 additions, -125 deletions)

View changed files

📝 backend/open_webui/models/functions.py (+11 -0)
📝 backend/open_webui/utils/models.py (+120 -125)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Optimized the get_all_models() function to reduce run time from 1.5~ seconds to 0.54~ seconds (in my environment) for about a 60%~ speed improvement.
The 0.5~ seconds is mostly from the get_all_base_models method.

Added

Functions.get_functions_by_ids() to batch multiple function lookups by id
Dictionary-based lookups for custom models and functions
Error handling for function module loading

Changed

Replaced individual database calls with batch queries using Functions.get_functions_by_ids()
Converted lists operations to sets for faster speed.
Pre-calculate action/filter IDs and store temporarily to avoid redundant processing
Restructured custom model processing logic to use dictionary lookups instead of nested loops
Modified function module loading to use centralized caching mechanism
Replaced list concatenation with extend() method for better memory efficiency

Deprecated

None

Removed

Redundant database queries within model processing loops
Repeated function module loading operations
Inefficient list management / concatenation

Breaking Changes

NONE I FOUND - All changes are just re-writes and optimizations of the original code, in theory the input -> output should be exactly the same. The function input parameters, and output structure remain unchanged.

Additional Information

~~This code likely works though I haven't thoroughly tested it.~~
Tested the code locally, works great and its consistently faster. Editing models, filters, functions and pipes work.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14427 **Author:** [@torisetxd](https://github.com/torisetxd) **Created:** 5/27/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `optimize-model-fetching-v2` --- ### 📝 Commits (1) - [`dd70595`](https://github.com/open-webui/open-webui/commit/dd70595a1a21a8ed5df5b7f9de3541696a257522) Add function to retrieve functions by IDs and optimize model fetching logic ### 📊 Changes **2 files changed** (+131 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/functions.py` (+11 -0) 📝 `backend/open_webui/utils/models.py` (+120 -125) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Optimized the `get_all_models()` function to reduce run time from 1.5~ seconds to 0.54~ seconds (in my environment) for about a 60%~ speed improvement. - The 0.5~ seconds is mostly from the `get_all_base_models` method. ### Added - `Functions.get_functions_by_ids()` to batch multiple function lookups by id - Dictionary-based lookups for custom models and functions - Error handling for function module loading ### Changed - Replaced individual database calls with batch queries using `Functions.get_functions_by_ids()` - Converted lists operations to sets for faster speed. - Pre-calculate action/filter IDs and store temporarily to avoid redundant processing - Restructured custom model processing logic to use dictionary lookups instead of nested loops - Modified function module loading to use centralized caching mechanism - Replaced list concatenation with `extend()` method for better memory efficiency ### Deprecated - None ### Removed - Redundant database queries within model processing loops - Repeated function module loading operations - Inefficient list management / concatenation ### Breaking Changes - **NONE I FOUND** - All changes are just re-writes and optimizations of the original code, in theory the input -> output should be exactly the same. The function input parameters, and output structure remain unchanged. --- ### Additional Information - ~~**This code likely works though I haven't thoroughly tested it.**~~ - Tested the code locally, works great and its consistently faster. Editing models, filters, functions and pipes work. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:50:26 -05:00

GiteaMirror closed this issue

2026-04-25 11:50:26 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39098