[PR #14245] [MERGED] perf Update mistral.py #39049

Closed
opened 2026-04-25 11:46:44 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14245
Author: @PVBLIC-F
Created: 5/23/2025
Status: Merged
Merged: 5/23/2025
Merged by: @tjbck

Base: devHead: dev


📝 Commits (1)

📊 Changes

1 file changed (+423 additions, -73 deletions)

View changed files

📝 backend/open_webui/retrieval/loaders/mistral.py (+423 -73)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Enhanced the MistralLoader class to support both synchronous and asynchronous operations while maintaining 100% backward compatibility. This update significantly improves performance for OCR processing workflows.

  • Key Implementation Features

  • Session Management: Optimized aiohttp.ClientSession with connection pooling

  • Error Recovery: Exponential backoff with configurable retry attempts

  • Memory Efficiency: Streaming uploads for large files

  • Resource Cleanup: Guaranteed cleanup with context managers and finally blocks

  • Metrics & Logging: Enhanced logging with timing and debug information

Added

  • Async Support: Added load_async() method for high-performance async operations
  • Batch Processing: Added load_multiple_async() static method for concurrent file processing
  • Enhanced Error Handling: Improved error messages with response content and timing metrics
  • Retry Logic: Exponential backoff retry mechanism for both sync and async operations
  • Configurable Timeouts: Customizable timeout settings for different file sizes
  • Debug Logging: Optional detailed logging for troubleshooting performance issues
    • Connection Pooling: Optimized HTTP connection reuse with aiohttp
  • Streaming Uploads: Memory-efficient file uploads using MultipartWriter
  • Resource Management: Proper session cleanup with context managers
  • DNS Caching: Reduces lookup overhead for repeated API calls

Dependencies Added

  • aiohttp - For async HTTP operations
  • asyncio - For async coordination
  • time - For performance timing
  • contextlib - For context manager support

Changed

  • Zero Breaking Changes: All existing code continues to work unchanged
  • Same Interface: Original load() method unchanged
  • Drop-in Replacement: Can replace existing file without code modifications

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • [List any fixes, corrections, or bug fixes]

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

  • [Insert any additional context, notes, or explanations for the changes]
    • [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14245 **Author:** [@PVBLIC-F](https://github.com/PVBLIC-F) **Created:** 5/23/2025 **Status:** ✅ Merged **Merged:** 5/23/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`bf193df`](https://github.com/open-webui/open-webui/commit/bf193dfb5dc76828b9afa4c8c3f746440ec78bce) Update mistral.py ### 📊 Changes **1 file changed** (+423 additions, -73 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/loaders/mistral.py` (+423 -73) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Enhanced the MistralLoader class to support both synchronous and asynchronous operations while maintaining 100% backward compatibility. This update significantly improves performance for OCR processing workflows. - ### Key Implementation Features - **Session Management**: Optimized aiohttp.ClientSession with connection pooling - **Error Recovery**: Exponential backoff with configurable retry attempts - **Memory Efficiency**: Streaming uploads for large files - **Resource Cleanup**: Guaranteed cleanup with context managers and finally blocks - **Metrics & Logging**: Enhanced logging with timing and debug information ### Added - **Async Support**: Added `load_async()` method for high-performance async operations - **Batch Processing**: Added `load_multiple_async()` static method for concurrent file processing - **Enhanced Error Handling**: Improved error messages with response content and timing metrics - **Retry Logic**: Exponential backoff retry mechanism for both sync and async operations - **Configurable Timeouts**: Customizable timeout settings for different file sizes - **Debug Logging**: Optional detailed logging for troubleshooting performance issues - - **Connection Pooling**: Optimized HTTP connection reuse with aiohttp - **Streaming Uploads**: Memory-efficient file uploads using MultipartWriter - **Resource Management**: Proper session cleanup with context managers - **DNS Caching**: Reduces lookup overhead for repeated API calls ### Dependencies Added - `aiohttp` - For async HTTP operations - `asyncio` - For async coordination - `time` - For performance timing - `contextlib` - For context manager support ### Changed - **Zero Breaking Changes**: All existing code continues to work unchanged - **Same Interface**: Original `load()` method unchanged - **Drop-in Replacement**: Can replace existing file without code modifications ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - [List any fixes, corrections, or bug fixes] ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 11:46:44 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#39049