[PR #14073] [MERGED] fix: Default web loader fail silently when verify_ssl=False #39009

New Issue

GiteaMirror · 2026-04-25T11:45:43-05:00

GiteaMirror commented

2026-04-25 11:45:43 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14073
Author: @tth37
Created: 5/20/2025
Status: ✅ Merged
Merged: 5/20/2025
Merged by: @tjbck

Base: dev ← Head: fix_default_web_loader_verify_ssl

📝 Commits (1)

78befd5 fix: Default web loader fail when verify_ssl=False

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 backend/open_webui/retrieval/web/utils.py (+0 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

After b143c71da2, many users have reported that the default web loader fails silently #13453 #14008 #14029. This issue is most likely triggered by the following code snippet:

async with session.get(
    url,
    **(self.requests_kwargs | kwargs),
    ssl=AIOHTTP_CLIENT_SESSION_SSL,
)

When verify_ssl=False, the kwargs dictionary already contains kwargs['ssl']=False. This results in a duplicate ssl key being passed to session.get, causing the requests library to throw an error. However, since continue_on_failure is enabled, this error is not raised and instead fails silently.

Removed

Removed the duplicate ssl key in the default web loader to prevent the silent failure.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14073 **Author:** [@tth37](https://github.com/tth37) **Created:** 5/20/2025 **Status:** ✅ Merged **Merged:** 5/20/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix_default_web_loader_verify_ssl` --- ### 📝 Commits (1) - [`78befd5`](https://github.com/open-webui/open-webui/commit/78befd5a2fb04233cb7a3a2d11e59a77acf243b2) fix: Default web loader fail when `verify_ssl=False` ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/web/utils.py` (+0 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description After b143c71da266ce9f50a216c3f4ea8395b3bba127, many users have reported that the default web loader fails silently #13453 #14008 #14029. This issue is most likely triggered by the following code snippet: ```python3 async with session.get( url, **(self.requests_kwargs | kwargs), ssl=AIOHTTP_CLIENT_SESSION_SSL, ) ``` When `verify_ssl=False`, the `kwargs` dictionary already contains `kwargs['ssl']=False`. This results in a duplicate `ssl` key being passed to `session.get`, causing the requests library to throw an error. However, since `continue_on_failure` is enabled, this error is not raised and instead fails silently. ### Removed - Removed the duplicate `ssl` key in the default web loader to prevent the silent failure. --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:45:43 -05:00

GiteaMirror closed this issue

2026-04-25 11:45:44 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39009

[PR #14073] [MERGED] fix: Default web loader fail silently when verify_ssl=False #39009