[PR #13955] [CLOSED] Contrast in settings modal - to make accessible for visually impaired users #38971

Closed
opened 2026-04-25 11:44:41 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13955
Author: @sinejespersen
Created: 5/16/2025
Status: ❌ Closed

Base: dev ← Head: feature/contrast-in-settings-modal-tabs


📝 Commits (1)

  • 99840d0 contrast in settings modal - to make accessible for visually impaired users

📊 Changes

1 file changed (+30 additions, -30 deletions)

View changed files

📝 src/lib/components/chat/SettingsModal.svelte (+30 -30)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fix the color contrast on tabs to be in accordance with WCAG 2.1 in settings modal tabs (both dark and light mode)

Added

  • [List any new features, functionalities, or additions]

Changed

  • [List any changes, updates, refactorings, or optimizations]

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • [List any fixes, corrections, or bug fixes]

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

I have created something like this earlier where a comment stated that "they conflict with our design language.". If this does as well, will you please refer me to a style guide or something so I make create this in a suitable manner?

Screenshots or Videos

Screenshot 2025-05-16 at 13 10 48 Screenshot 2025-05-16 at 13 10 08

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13955 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 5/16/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feature/contrast-in-settings-modal-tabs` --- ### 📝 Commits (1) - [`99840d0`](https://github.com/open-webui/open-webui/commit/99840d08f93f4a71d934a5fb1499cd6a8cd277f6) contrast in settings modal - to make accessible for visually impaired users ### 📊 Changes **1 file changed** (+30 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/SettingsModal.svelte` (+30 -30) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Fix the color contrast on tabs to [be in accordance with WCAG 2.1 ](https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html) in settings modal tabs (both dark and light mode) ### Added - [List any new features, functionalities, or additions] ### Changed - [List any changes, updates, refactorings, or optimizations] ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - [List any fixes, corrections, or bug fixes] ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information [I have created something like this earlier](https://github.com/open-webui/open-webui/pull/13879) where a comment stated that "_they conflict with our design language._". If this does as well, will you please refer me to a style guide or something so I make create this in a suitable manner? ### Screenshots or Videos <img width="924" alt="Screenshot 2025-05-16 at 13 10 48" src="https://github.com/user-attachments/assets/7a7aa3a5-3fdd-4d2d-89b8-79278c805641" /> <img width="939" alt="Screenshot 2025-05-16 at 13 10 08" src="https://github.com/user-attachments/assets/3e141dac-6c07-4066-93df-d1280ced73a6" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 11:44:41 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#38971