[PR #13738] [MERGED] fix: allow non-root jupyter base_url #38905

Closed
opened 2026-04-25 11:42:40 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13738
Author: @dataway
Created: 5/9/2025
Status: Merged
Merged: 5/10/2025
Merged by: @tjbck

Base: devHead: dev


📝 Commits (1)

  • 337ece4 code_interpreter.py: allow non-root jupyter base_url

📊 Changes

1 file changed (+9 additions, -7 deletions)

View changed files

📝 backend/open_webui/utils/code_interpreter.py (+9 -7)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • [x ] Target branch: Please verify that the pull request targets the dev branch.
  • [x ] Description: Provide a concise description of the changes made in this pull request.
  • [x ] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • [n/a ] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • [x ] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • [x ] Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

The code_interpreter.py did not function correctly for Jupyter server instances running under an URL with a prefix. If for example the Jupyter server was available at http://server.example.com/jupyter/ the /jupyter/ part of the URL was ignored. This fixes this bug.

To test, launch:
jupyter-lab --ServerApp.base_url=/jupyter/

Added

Changed

Deprecated

Removed

Fixed

code_interpreter.py: class JupyterCodeExecuter now stores the base_url WITH trailing slash (adding one if not provided), and then executes self.session.get/post WITHOUT leading slash. The init_ws function was also fixed to not mess up URLs that happen to contain the string "http".

Security

Breaking Changes


Additional Information

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13738 **Author:** [@dataway](https://github.com/dataway) **Created:** 5/9/2025 **Status:** ✅ Merged **Merged:** 5/10/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`337ece4`](https://github.com/open-webui/open-webui/commit/337ece4d5099579f1f9383e4bb94d3e2daeb61cf) code_interpreter.py: allow non-root jupyter base_url ### 📊 Changes **1 file changed** (+9 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/code_interpreter.py` (+9 -7) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x ] **Description:** Provide a concise description of the changes made in this pull request. - [x ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [n/a ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description The code_interpreter.py did not function correctly for Jupyter server instances running under an URL with a prefix. If for example the Jupyter server was available at `http://server.example.com/jupyter/` the `/jupyter/` part of the URL was ignored. This fixes this bug. To test, launch: `jupyter-lab --ServerApp.base_url=/jupyter/` ### Added ### Changed ### Deprecated ### Removed ### Fixed code_interpreter.py: class JupyterCodeExecuter now stores the base_url WITH trailing slash (adding one if not provided), and then executes self.session.get/post WITHOUT leading slash. The init_ws function was also fixed to not mess up URLs that happen to contain the string "http". ### Security ### Breaking Changes --- ### Additional Information ### Screenshots or Videos ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 11:42:40 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#38905