[PR #13567] [MERGED] fix(katex): Allow CJK characters adjacent to math delimiters #38868

New Issue

GiteaMirror · 2026-04-25T11:41:11-05:00

GiteaMirror commented

2026-04-25 11:41:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13567
Author: @tth37
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/8/2025
Merged by: @tjbck

Base: dev ← Head: fix_katex_chinese_delimiters

📝 Commits (2)

de182dd fix(katex): Allow Chinese characters adjacent to math delimiters
8e14372 enh: Support more languages

📊 Changes

1 file changed (+12 additions, -3 deletions)

View changed files

📝 src/lib/utils/marked/katex-extension.ts (+12 -3)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

The current regex patterns reject math delimiters ( $...$ , etc.) when they appear directly against Chinese characters (e.g., $A$等于$B$). This is particularly problematic because that many LLMs naturally output math expressions adjacent to Chinese text without spacing (e.g., 这里，$A$是一个矩阵，$E$是单位矩阵, more examples discussed in #13487). However, our katex validation rules require special characters/whitespace around delimiters, causing Chinese+math combinations failed to render.

(Notably, in native marked-katex-extension, this case is correctly handled.)

Changed

Introduced ALLOWED_SURROUNDING_CHARS constant
Added Unicode \p{Script=Han} support, updated the parsing logic in lookahead checks ($x$中文) and preceding checks (中文$x$)
Maintained all existing punctuation/whitespace rules

Testings

I've also conducted some regression tests, and they all passed.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13567 **Author:** [@tth37](https://github.com/tth37) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix_katex_chinese_delimiters` --- ### 📝 Commits (2) - [`de182dd`](https://github.com/open-webui/open-webui/commit/de182ddec24a37ae37481f080684b98701b631b9) fix(katex): Allow Chinese characters adjacent to math delimiters - [`8e14372`](https://github.com/open-webui/open-webui/commit/8e14372dd830e7d3291b32fcefed15a07d2865f5) enh: Support more languages ### 📊 Changes **1 file changed** (+12 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/utils/marked/katex-extension.ts` (+12 -3) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description The current regex patterns reject math delimiters (`$...$`, etc.) when they appear directly against Chinese characters (e.g., `$A$等于$B$`). This is particularly problematic because that many LLMs naturally output math expressions adjacent to Chinese text **without spacing** (e.g., `这里，$A$是一个矩阵，$E$是单位矩阵`, more examples discussed in #13487). However, our katex validation rules require **special characters/whitespace around delimiters**, causing Chinese+math combinations failed to render. (Notably, in native [`marked-katex-extension`](https://www.npmjs.com/package/marked-katex-extension), this case is correctly handled.) ![owui](https://github.com/user-attachments/assets/a6754ce0-e2ba-468b-bf89-cd8e5796885a) ### Changed - Introduced `ALLOWED_SURROUNDING_CHARS` constant - Added Unicode `\p{Script=Han}` support, updated the parsing logic in lookahead checks (`$x$中文`) and preceding checks (`中文$x$`) - Maintained all existing punctuation/whitespace rules ### Testings ![chinese](https://github.com/user-attachments/assets/98704a12-b4ec-49e6-a4aa-f7d2b77ad424) ![japanese](https://github.com/user-attachments/assets/d02c96f5-7d55-428e-a1b7-cf986700d3a3) ![korean](https://github.com/user-attachments/assets/4771589c-a92c-4e0f-b6f0-60fdff772e8e) I've also conducted some regression tests, and they all passed. --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:41:11 -05:00

GiteaMirror closed this issue

2026-04-25 11:41:13 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#38868