[PR #12717] [MERGED] feat: Add PWA external manifest URL env var #38638

Closed
opened 2026-04-25 11:34:02 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/12717
Author: @Kheiden
Created: 4/10/2025
Status: Merged
Merged: 4/10/2025
Merged by: @tjbck

Base: devHead: progressive-webapp-enhancements


📝 Commits (1)

  • c12f8d2 Add PWA external manifest URL env var

📊 Changes

2 files changed (+35 additions, -23 deletions)

View changed files

📝 backend/open_webui/env.py (+7 -0)
📝 backend/open_webui/main.py (+28 -23)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • [ x] Target branch: Please verify that the pull request targets the dev branch.
  • [ x] Description: Provide a concise description of the changes made in this pull request.
  • [ x] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • [ x] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • [ x] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • [x ] Testing: Have you written and run sufficient tests to validate the changes?
  • [ x] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • [ x] Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

-I propose the addition of a new environment variable EXTERNAL_PWA_MANIFEST_URL which when defined allows the solution to use an external manifest file (such as one hosted on a CDN). If the envvar EXTERNAL_PWA_MANIFEST_URL is not defined, the default PWA manifest will be used.

Added

  • A new environment variable EXTERNAL_PWA_MANIFEST_URL which when defined allows the solution to use an external manifest file.

Changed

  • The route "/manifest.json" has been changed to return data based on if the EXTERNAL_PWA_MANIFEST_URL env var is defined.

Deprecated

  • N/A

Removed

  • N/A

Fixed

  • N/A

Security

  • N/A

Breaking Changes

  • N/A

Additional Information

Discussion is available here:
https://github.com/open-webui/open-webui/discussions/12661

Screenshots or Videos

  • N/A

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/12717 **Author:** [@Kheiden](https://github.com/Kheiden) **Created:** 4/10/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `progressive-webapp-enhancements` --- ### 📝 Commits (1) - [`c12f8d2`](https://github.com/open-webui/open-webui/commit/c12f8d28b9bef1107e614ce19341deef4c2ca099) Add PWA external manifest URL env var ### 📊 Changes **2 files changed** (+35 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/env.py` (+7 -0) 📝 `backend/open_webui/main.py` (+28 -23) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ x] **Description:** Provide a concise description of the changes made in this pull request. - [ x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description -I propose the addition of a new environment variable `EXTERNAL_PWA_MANIFEST_URL` which when defined allows the solution to use an external manifest file (such as one hosted on a CDN). If the envvar EXTERNAL_PWA_MANIFEST_URL is not defined, the default PWA manifest will be used. ### Added - A new environment variable `EXTERNAL_PWA_MANIFEST_URL` which when defined allows the solution to use an external manifest file. ### Changed - The route "/manifest.json" has been changed to return data based on if the `EXTERNAL_PWA_MANIFEST_URL` env var is defined. ### Deprecated - N/A ### Removed - N/A ### Fixed - N/A ### Security - N/A ### Breaking Changes - N/A --- ### Additional Information Discussion is available here: https://github.com/open-webui/open-webui/discussions/12661 ### Screenshots or Videos - N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 11:34:02 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#38638