[PR #12647] [MERGED] fix: choose the first mail if multiple are returned from LDAP #38625

New Issue

GiteaMirror · 2026-04-25T11:33:41-05:00

GiteaMirror commented

2026-04-25 11:33:41 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/12647
Author: @behrmann
Created: 4/9/2025
Status: ✅ Merged
Merged: 4/9/2025
Merged by: @tjbck

Base: dev ← Head: multimail

📝 Commits (1)

2e7a01f fix: choose the first mail if multiple are returned from LDAP

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 backend/open_webui/routers/auths.py (+5 -3)

📄 Description

Pull Request Checklist

If an LDAP entry has multiple mail attributes, the returned entry object has a list of strings as the mail attribute. This is stringified here, which produces non-sense mail addresses like ["foo@example.com", "bar@example.com"].

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

LDAP entries for users with list-based LDAP entries use the first email address instead of wrongly using the whole list as a string.

Added

LDAP-backed users with multiple email addresses are supported for the first time.

Fixed

LDAP entries for users with list-based LDAP entries use the first email address instead of wrongly using the whole list as a string.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/12647 **Author:** [@behrmann](https://github.com/behrmann) **Created:** 4/9/2025 **Status:** ✅ Merged **Merged:** 4/9/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `multimail` --- ### 📝 Commits (1) - [`2e7a01f`](https://github.com/open-webui/open-webui/commit/2e7a01f30adb5e641805f2c37921d111f955f31d) fix: choose the first mail if multiple are returned from LDAP ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/auths.py` (+5 -3) </details> ### 📄 Description # Pull Request Checklist If an LDAP entry has multiple mail attributes, the returned entry object has a list of strings as the mail attribute. This is stringified [here](https://github.com/open-webui/open-webui/blob/63533c9e3ab41edd7bd4124ef94f6b6dc09aa175/backend/open_webui/routers/auths.py#L233), which produces non-sense mail addresses like ["foo@example.com", "bar@example.com"]. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - LDAP entries for users with list-based LDAP entries use the first email address instead of wrongly using the whole list as a string. ### Added - LDAP-backed users with multiple email addresses are supported for the first time. ### Fixed - LDAP entries for users with list-based LDAP entries use the first email address instead of wrongly using the whole list as a string. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:33:41 -05:00

GiteaMirror closed this issue

2026-04-25 11:33:42 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#38625