[PR #10994] [CLOSED] Refactor Sidebar's "new chat" from global element querying to event propagation and function call #38265

New Issue

GiteaMirror · 2026-04-25T11:21:34-05:00

GiteaMirror commented

2026-04-25 11:21:34 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10994
Author: @thlehmann-ionos
Created: 2/28/2025
Status: ❌ Closed

Base: dev ← Head: tl/refactor-sidebar-new-chat

📝 Commits (2)

ab4b326 chore(app): refactor Sidebar from +layout to +pages
3d94173 chore(Chat): start new chat though explicit function call

📊 Changes

10 files changed (+31 additions, -7 deletions)

View changed files

📝 src/lib/components/chat/Chat.svelte (+5 -0)
📝 src/lib/components/layout/Sidebar.svelte (+4 -3)
📝 src/routes/(app)/+layout.svelte (+0 -2)
📝 src/routes/(app)/+page.svelte (+5 -1)
📝 src/routes/(app)/admin/+layout.svelte (+3 -0)
📝 src/routes/(app)/c/[id]/+page.svelte (+5 -1)
📝 src/routes/(app)/channels/[id]/+page.svelte (+2 -0)
📝 src/routes/(app)/playground/+layout.svelte (+3 -0)
📝 src/routes/(app)/workspace/+layout.svelte (+3 -0)
📝 src/routes/(app)/workspace/+page.svelte (+1 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes? (no tests)
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

It was refactored how a new chat is started from the sidebar to not rely on the presence of the new chat button in the top toolbar. This reduces inter-component dependencies and makes the code easier to read.

Added

Changed

New chat initiation via the side bar changed from getElementById('new-chat-button').click() of the link in the Navbar (top menubar) to propagating an event up and calling a new chat start function (newChat()) on the Chat component explicitly.

Deprecated

Removed

Fixed

Security

Breaking Changes

Additional Information

Context: customization of Open WebUI where the Navbar's "new chat" button will be removed

Manual test cases

"New chat" via sidebar successfully tested in:

Chat (no dialog)
Chat (dialog)
Playground
Workspace
Admin panel

"New chat" via top menubar (Navbar) (with Sidebar closed) successfully tested in:

Chat

Second "New chat" after "New chat" with submitting the chat successfully tested for:

Sidebar
Top menubar (Navbar)

Not tested:

Channels (unable to find how to enter them)

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10994 **Author:** [@thlehmann-ionos](https://github.com/thlehmann-ionos) **Created:** 2/28/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `tl/refactor-sidebar-new-chat` --- ### 📝 Commits (2) - [`ab4b326`](https://github.com/open-webui/open-webui/commit/ab4b326f7c128a05364256d5df85723692bb825a) chore(app): refactor Sidebar from +layout to +pages - [`3d94173`](https://github.com/open-webui/open-webui/commit/3d94173db6fafd11def9e5d290eebf9ffbf33aa2) chore(Chat): start new chat though explicit function call ### 📊 Changes **10 files changed** (+31 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Chat.svelte` (+5 -0) 📝 `src/lib/components/layout/Sidebar.svelte` (+4 -3) 📝 `src/routes/(app)/+layout.svelte` (+0 -2) 📝 `src/routes/(app)/+page.svelte` (+5 -1) 📝 `src/routes/(app)/admin/+layout.svelte` (+3 -0) 📝 `src/routes/(app)/c/[id]/+page.svelte` (+5 -1) 📝 `src/routes/(app)/channels/[id]/+page.svelte` (+2 -0) 📝 `src/routes/(app)/playground/+layout.svelte` (+3 -0) 📝 `src/routes/(app)/workspace/+layout.svelte` (+3 -0) 📝 `src/routes/(app)/workspace/+page.svelte` (+1 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] ~**Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?~ - [x] ~**Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?~ - [x] ~**Testing:** Have you written and run sufficient tests for validating the changes?~ _(no tests)_ - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description It was refactored how a new chat is started from the sidebar to not rely on the presence of the new chat button in the top toolbar. This reduces inter-component dependencies and makes the code easier to read. ### Added ### Changed - New chat initiation via the side bar changed from `getElementById('new-chat-button').click()` of the link in the Navbar (top menubar) to propagating an event up and calling a new chat start function (`newChat()`) on the Chat component explicitly. ### Deprecated ### Removed ### Fixed ### Security ### Breaking Changes --- ### Additional Information - Context: customization of Open WebUI where the Navbar's "new chat" button will be removed ### Manual test cases "New chat" via sidebar successfully tested in: * Chat (no dialog) * Chat (dialog) * Playground * Workspace * Admin panel "New chat" via top menubar (Navbar) (with Sidebar closed) successfully tested in: * Chat Second "New chat" after "New chat" with submitting the chat successfully tested for: * Sidebar * Top menubar (Navbar) Not tested: * Channels (unable to find how to enter them) ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:21:34 -05:00

GiteaMirror closed this issue

2026-04-25 11:21:36 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#38265