[PR #9865] [MERGED] fix - Fixes citation modal toggle when clicking inliine citations and # citations > 3 #38058

New Issue

GiteaMirror · 2026-04-25T11:15:15-05:00

GiteaMirror commented

2026-04-25 11:15:15 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/9865
Author: @feynmanliang
Created: 2/12/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @tjbck

Base: dev ← Head: fix-9864

📝 Commits (4)

3f24062 Adds source-* ids when citations > 3
08bc7d4 Uncollapse so all source buttons visible
113adde Merge branch 'dev' into fix-9864
361a989 Retab collapsible

📊 Changes

3 files changed (+21 additions, -3 deletions)

View changed files

📝 src/lib/components/chat/Messages/Citations.svelte (+2 -0)
📝 src/lib/components/chat/Messages/ResponseMessage.svelte (+17 -2)
📝 src/lib/components/common/Collapsible.svelte (+2 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

OpenWebUI PR #9865 for fixing issue #9864 - Watch Video

Changelog Entry

Description

Adds source-* ids to citation buttons when number of sources > 3

Added

n/a

Changed

Citation buttons when sources > 3 now have IDs

Deprecated

n/a

Removed

n/a

Fixed

Fixes [PR #12974] [MERGED] fix: improve international character handling in prompt commands (#9864)

Security

n/a

Breaking Changes

n/a

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/9865 **Author:** [@feynmanliang](https://github.com/feynmanliang) **Created:** 2/12/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-9864` --- ### 📝 Commits (4) - [`3f24062`](https://github.com/open-webui/open-webui/commit/3f24062416b8e9b0ba5692dc1057fa13d85223b6) Adds source-* ids when citations > 3 - [`08bc7d4`](https://github.com/open-webui/open-webui/commit/08bc7d4cfe7da29b869cba78c341af8c0af76d1b) Uncollapse so all source buttons visible - [`113adde`](https://github.com/open-webui/open-webui/commit/113addef4627362bc0c472bf623df21d7da56e0c) Merge branch 'dev' into fix-9864 - [`361a989`](https://github.com/open-webui/open-webui/commit/361a98980e7cc7763d16f5522a05c7188bab4c0e) Retab collapsible ### 📊 Changes **3 files changed** (+21 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/Citations.svelte` (+2 -0) 📝 `src/lib/components/chat/Messages/ResponseMessage.svelte` (+17 -2) 📝 `src/lib/components/common/Collapsible.svelte` (+2 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work [OpenWebUI PR #9865 for fixing issue #9864 - Watch Video](https://www.loom.com/share/c054bce505cc491dbc11b0568f1d5129) # Changelog Entry ### Description - Adds `source-*` ids to citation buttons when number of sources > 3 ### Added - n/a ### Changed - Citation buttons when sources > 3 now have IDs ### Deprecated - n/a ### Removed - n/a ### Fixed - Fixes #9864 ### Security - n/a ### Breaking Changes - n/a --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:15:15 -05:00

GiteaMirror closed this issue

2026-04-25 11:15:16 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#38058