Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
No discussion post, saw this bug in my own testing
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
None
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
fix: Bug fix or error correction
Changelog Entry
Description
Admins logging in to an Open WebUI instance with Oauth group management would be added to groups previously. This led to issues where group member counts and members listed would misalign, as admins do not show on these lists - they don't need to be added to any groups as they see them all.
Fixed
Prevented admins from being added to groups using Oauth group management
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/8371
**Author:** [@tarmst](https://github.com/tarmst)
**Created:** 1/6/2025
**Status:** ✅ Merged
**Merged:** 1/6/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `fix-admins-added-to-groups-from-oauth-group-mgmt`
---
### 📝 Commits (1)
- [`8117bf8`](https://github.com/open-webui/open-webui/commit/8117bf8603527e570a802c8496d78ac760ca6dd4) Add admin check
### 📊 Changes
**1 file changed** (+1 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/utils/oauth.py` (+1 -1)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
No discussion post, saw this bug in my own testing
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- None
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **fix**: Bug fix or error correction
# Changelog Entry
### Description
Admins logging in to an Open WebUI instance with Oauth group management would be added to groups previously. This led to issues where group member counts and members listed would misalign, as admins do not show on these lists - they don't need to be added to any groups as they see them all.
### Fixed
- Prevented admins from being added to groups using Oauth group management
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/8371
Author: @tarmst
Created: 1/6/2025
Status: ✅ Merged
Merged: 1/6/2025
Merged by: @tjbck
Base:
dev← Head:fix-admins-added-to-groups-from-oauth-group-mgmt📝 Commits (1)
8117bf8Add admin check📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
backend/open_webui/utils/oauth.py(+1 -1)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
No discussion post, saw this bug in my own testing
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Admins logging in to an Open WebUI instance with Oauth group management would be added to groups previously. This led to issues where group member counts and members listed would misalign, as admins do not show on these lists - they don't need to be added to any groups as they see them all.
Fixed
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.