github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 06:03:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #7199] [CLOSED] Refactor: get all models functions naming and logging improvements #37655

New Issue
Closed
opened 2026-04-25 11:01:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 11:01:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/7199
Author: @DmitriyAlergant
Created: 11/22/2024
Status: ❌ Closed

Base: dev ← Head: get_all_models_refac

📝 Commits (7)

  • f9333e2 Merge pull request #1 from open-webui/main
  • 8a3e5f7 Merge pull request #2 from open-webui/dev
  • db4e9c5 Refactoring (improved function naming, some code deduplication for modules loading)
  • 291822b Added dev debug starter script with debug logging
  • 7694fe8 Logging cleanup
  • 789756b Merge pull request #3 from open-webui/dev
  • c3a12da Merge branch 'dev' into get_all_models_refac

📊 Changes

8 files changed (+191 additions, -169 deletions)

View changed files

➕ backend/dev_debug.sh (+9 -0)
📝 backend/open_webui/apps/ollama/main.py (+12 -12)
📝 backend/open_webui/apps/openai/main.py (+4 -4)
📝 backend/open_webui/apps/webui/main.py (+21 -29)
📝 backend/open_webui/apps/webui/models/models.py (+1 -1)
📝 backend/open_webui/apps/webui/routers/functions.py (+4 -0)
📝 backend/open_webui/apps/webui/utils.py (+29 -1)
📝 backend/open_webui/main.py (+111 -122)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • [N/A] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • [N/A] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Code refactoring (methods naming, some DRY) for better readability
  • Some cleanups of stdoud and debug-level logging. Should not be spilling chat messages content to the log (at least in some places where it was doing so before).

Fixed

  • Some cleanups of stdoud and debug-level logging

Additional Information

Screenshots or Videos

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/7199 **Author:** [@DmitriyAlergant](https://github.com/DmitriyAlergant) **Created:** 11/22/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `get_all_models_refac` --- ### 📝 Commits (7) - [`f9333e2`](https://github.com/open-webui/open-webui/commit/f9333e2ac2ec890626ccad0f89edea22dcaf371a) Merge pull request #1 from open-webui/main - [`8a3e5f7`](https://github.com/open-webui/open-webui/commit/8a3e5f763915c048c626aad1941a1f0ca0c5bd27) Merge pull request #2 from open-webui/dev - [`db4e9c5`](https://github.com/open-webui/open-webui/commit/db4e9c55d70645ba1f5886af2fca5cc15b805393) Refactoring (improved function naming, some code deduplication for modules loading) - [`291822b`](https://github.com/open-webui/open-webui/commit/291822bdccc0e09a388a6129c2e2ff123beeddf3) Added dev debug starter script with debug logging - [`7694fe8`](https://github.com/open-webui/open-webui/commit/7694fe88b4063feeba9b5c7f7ea912aa86f97e2f) Logging cleanup - [`789756b`](https://github.com/open-webui/open-webui/commit/789756b641a9910c93e5141c2e155bab17e1ae73) Merge pull request #3 from open-webui/dev - [`c3a12da`](https://github.com/open-webui/open-webui/commit/c3a12da328ce8a92cab9a4242e93e37159ca400a) Merge branch 'dev' into get_all_models_refac ### 📊 Changes **8 files changed** (+191 additions, -169 deletions) <details> <summary>View changed files</summary> ➕ `backend/dev_debug.sh` (+9 -0) 📝 `backend/open_webui/apps/ollama/main.py` (+12 -12) 📝 `backend/open_webui/apps/openai/main.py` (+4 -4) 📝 `backend/open_webui/apps/webui/main.py` (+21 -29) 📝 `backend/open_webui/apps/webui/models/models.py` (+1 -1) 📝 `backend/open_webui/apps/webui/routers/functions.py` (+4 -0) 📝 `backend/open_webui/apps/webui/utils.py` (+29 -1) 📝 `backend/open_webui/main.py` (+111 -122) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [N/A] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [N/A] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests for validating the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Code refactoring (methods naming, some DRY) for better readability - Some cleanups of stdoud and debug-level logging. Should not be spilling chat messages content to the log (at least in some places where it was doing so before). ### Fixed - Some cleanups of stdoud and debug-level logging ### Additional Information ### Screenshots or Videos --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 11:01:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#37655
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?