[PR #4768] [MERGED] fix: Fix parameter handling for PostgreSQL URLs #37187

New Issue

GiteaMirror · 2026-04-25T10:46:29-05:00

GiteaMirror commented

2026-04-25 10:46:29 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4768
Author: @zhaofengli
Created: 8/21/2024
Status: ✅ Merged
Merged: 8/22/2024
Merged by: @tjbck

Base: dev ← Head: db-url-fixes

📝 Commits (2)

a53c2a8 fix: Pass all parsed options to ReconnectingPostgresqlDatabase
e63d577 fix: Decode URL-encoded characters in passwords

📊 Changes

1 file changed (+3 additions, -9 deletions)

View changed files

📝 backend/apps/webui/internal/wrappers.py (+3 -9)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources? N/A
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation? N/A
Testing: Have you written and run sufficient tests for validating the changes? N/A
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR fixes PostgreSQL support so parameters like sslmode=require are honored and passwords containing special characters can be used.

Fixed

Correctly pass all parsed arguments to ReconnectingPostgresqlDatabase
Decode URL-encoded characters in passwords

Additional Information

Passing all parsed options as kwargs is the approach used in connect() in peewee. Without this fix, URLs without port numbers result in errors and parameters like sslmode=require are silently ignored.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4768 **Author:** [@zhaofengli](https://github.com/zhaofengli) **Created:** 8/21/2024 **Status:** ✅ Merged **Merged:** 8/22/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `db-url-fixes` --- ### 📝 Commits (2) - [`a53c2a8`](https://github.com/open-webui/open-webui/commit/a53c2a8c6b362f20a944ddb9e5a34a9fd97b3b44) fix: Pass all parsed options to ReconnectingPostgresqlDatabase - [`e63d577`](https://github.com/open-webui/open-webui/commit/e63d5778a864d5a3118244b85c347877acc06890) fix: Decode URL-encoded characters in passwords ### 📊 Changes **1 file changed** (+3 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/webui/internal/wrappers.py` (+3 -9) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? N/A - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? N/A - [x] **Testing:** Have you written and run sufficient tests for validating the changes? N/A - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR fixes PostgreSQL support so parameters like `sslmode=require` are honored and passwords containing special characters can be used. ### Fixed - Correctly pass all parsed arguments to ReconnectingPostgresqlDatabase - Decode URL-encoded characters in passwords --- ### Additional Information - Passing all parsed options as kwargs is the approach used in [`connect()` in peewee](https://github.com/coleifer/peewee/blob/6d59dd6c438c2e86ad10e0203e1734e71dfd4e2e/playhouse/db_url.py#L102). Without this fix, URLs without port numbers result in errors and parameters like `sslmode=require` are silently ignored. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 10:46:29 -05:00

GiteaMirror closed this issue

2026-04-25 10:46:30 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#37187