github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #4317] [CLOSED] chore: Refactor how user.role are checked into methods #37084

New Issue
Closed
opened 2026-04-25 10:43:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 10:43:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4317
Author: @leobenkel
Created: 8/3/2024
Status: ❌ Closed

Base: dev ← Head: refactor_role_check

📝 Commits (4)

📊 Changes

6 files changed (+28 additions, -16 deletions)

View changed files

📝 backend/apps/ollama/main.py (+2 -2)
📝 backend/apps/openai/main.py (+1 -1)
📝 backend/apps/webui/models/users.py (+12 -0)
📝 backend/apps/webui/routers/chats.py (+5 -5)
📝 backend/main.py (+1 -1)
📝 backend/utils/utils.py (+7 -7)

📄 Description

Pull Request Checklist

Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/discussions/4316

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Refactor how user.role are checked into methods

Added

  • Refactor how user.role are checked into methods

Changed

  • Refactor how user.role are checked into methods

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4317 **Author:** [@leobenkel](https://github.com/leobenkel) **Created:** 8/3/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `refactor_role_check` --- ### 📝 Commits (4) - [`a58dfcc`](https://github.com/open-webui/open-webui/commit/a58dfccb7dab4c7c42c8b4528f1d330bb1626e5f) Merge pull request #4273 from open-webui/dev - [`d3146d2`](https://github.com/open-webui/open-webui/commit/d3146d20ad74c020855142b2bf7e371f981ec098) Merge pull request #4304 from open-webui/dev - [`5e53c6e`](https://github.com/open-webui/open-webui/commit/5e53c6e4affe29457ebe74e471c85a41c5f0fa28) chore: Refactor how user.role are checked - [`d3222de`](https://github.com/open-webui/open-webui/commit/d3222de9ccaf7da3b6321a3fbadb360ab8a25794) fix ### 📊 Changes **6 files changed** (+28 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/ollama/main.py` (+2 -2) 📝 `backend/apps/openai/main.py` (+1 -1) 📝 `backend/apps/webui/models/users.py` (+12 -0) 📝 `backend/apps/webui/routers/chats.py` (+5 -5) 📝 `backend/main.py` (+1 -1) 📝 `backend/utils/utils.py` (+7 -7) </details> ### 📄 Description # Pull Request Checklist ### Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/discussions/4316 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Refactor how `user.role` are checked into methods ### Added - Refactor how `user.role` are checked into methods ### Changed - Refactor how `user.role` are checked into methods --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 10:43:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#37084
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?