[PR #4295] [MERGED] refactor: Refactor OpenAI API to use helper functions, silence LSP/linter warnings #37072

New Issue

GiteaMirror · 2026-04-25T10:42:51-05:00

GiteaMirror commented

2026-04-25 10:42:51 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4295
Author: @michaelpoluektov
Created: 8/2/2024
Status: ✅ Merged
Merged: 8/4/2024
Merged by: @tjbck

Base: dev ← Head: refactor-tools

📝 Commits (2)

12c21fa refac: apps/openai/main.py and utils
3653126 refac: undo raw split, remove gpt-4-vision-preview

📊 Changes

8 files changed (+160 additions, -240 deletions)

View changed files

📝 backend/apps/openai/main.py (+72 -143)
📝 backend/apps/socket/main.py (+15 -12)
📝 backend/apps/webui/main.py (+2 -43)
📝 backend/apps/webui/routers/tools.py (+13 -18)
📝 backend/main.py (+11 -16)
📝 backend/utils/misc.py (+43 -0)
📝 backend/utils/task.py (+1 -2)
📝 backend/utils/utils.py (+3 -6)

📄 Description

Pull Request Checklist

Sorry for the large amount of refactor PR's. I understand it's a pain to review but it's a lot easier to work on a project when you can rely on your LSP to hint at possible errors and not get inundated with warnings and whatnot.

This addresses a few things:

Helper functions introduced in #4237 are now re-used for OpenAI
A few files were auto-formatted
Silence LSP warnings (potentially unbound variables, inconsistencies in type annotations, including get_all_models)
Silence linter warnings (bare except:, unused imports, == None instead of is None, unused variables, function re-definition with the same name)

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Refactor everything around OpenAI API

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4295 **Author:** [@michaelpoluektov](https://github.com/michaelpoluektov) **Created:** 8/2/2024 **Status:** ✅ Merged **Merged:** 8/4/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `refactor-tools` --- ### 📝 Commits (2) - [`12c21fa`](https://github.com/open-webui/open-webui/commit/12c21fac22101f8f3a5fa8fcd2c9d15fd42ee89e) refac: apps/openai/main.py and utils - [`3653126`](https://github.com/open-webui/open-webui/commit/36531261795c731dd2c408ef0821d5eeccc54630) refac: undo raw split, remove gpt-4-vision-preview ### 📊 Changes **8 files changed** (+160 additions, -240 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/openai/main.py` (+72 -143) 📝 `backend/apps/socket/main.py` (+15 -12) 📝 `backend/apps/webui/main.py` (+2 -43) 📝 `backend/apps/webui/routers/tools.py` (+13 -18) 📝 `backend/main.py` (+11 -16) 📝 `backend/utils/misc.py` (+43 -0) 📝 `backend/utils/task.py` (+1 -2) 📝 `backend/utils/utils.py` (+3 -6) </details> ### 📄 Description # Pull Request Checklist Sorry for the large amount of refactor PR's. I understand it's a pain to review but it's a lot easier to work on a project when you can rely on your LSP to hint at possible errors and not get inundated with warnings and whatnot. This addresses a few things: - Helper functions introduced in #4237 are now re-used for OpenAI - A few files were auto-formatted - Silence LSP warnings (potentially unbound variables, inconsistencies in type annotations, including `get_all_models`) - Silence linter warnings (bare `except:`, unused imports, `== None` instead of `is None`, unused variables, function re-definition with the same name) **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Refactor everything around OpenAI API --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 10:42:51 -05:00

GiteaMirror closed this issue

2026-04-25 10:42:52 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#37072