Was going to add this with another PR to fix __event_emitter__ in Functions but thought this needed to be addressed separately.
Pull Request Checklist
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Refactor main.py
Changed
Remove unused imports
Remove unused declarations
Remove unnecessary nesting for readability
Refactor extra parameters into a separate loop
Ensure all variables are bound
Remove unused model parameter if model was overridden anyway
Refactor get_sorted_filters into a separate function
Tested with both functions and tools. No changes in functionality expected.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/3734
**Author:** [@michaelpoluektov](https://github.com/michaelpoluektov)
**Created:** 7/9/2024
**Status:** ✅ Merged
**Merged:** 7/9/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `refactor-main`
---
### 📝 Commits (10+)
- [`afd7421`](https://github.com/open-webui/open-webui/commit/afd74213cc3af8e9fe90ee7faa6c90853988184e) Update main.py
- [`0951475`](https://github.com/open-webui/open-webui/commit/09514751b553fd7713970af44033acf8f6e9f75a) Update main.py
- [`02f242e`](https://github.com/open-webui/open-webui/commit/02f242e9e81648ef2f4d6bf529e0821a87b4afb8) keep title, task, function tags for pipelines
- [`24c7990`](https://github.com/open-webui/open-webui/commit/24c7990fd4440b5c4734d8713302f47cd2a64c67) revert not delete on pipe
- [`49b4211`](https://github.com/open-webui/open-webui/commit/49b4211c06fa5ae886b01d0a857ef4011bdc5183) Merge branch 'dev' of https://github.com/open-webui/open-webui into dev
- [`f9e3c47`](https://github.com/open-webui/open-webui/commit/f9e3c47d4a536205cc0c105f1ef3e2d9469460ce) rebase
- [`e3e02e0`](https://github.com/open-webui/open-webui/commit/e3e02e04e87a39d858f42b588d8fa6aa5eca056c) refac: backend/main.py
- [`d7dd901`](https://github.com/open-webui/open-webui/commit/d7dd901f017568b0cd2a4ebfb1e3f0371b5f2fc6) refac: remove nesting
- [`ff47493`](https://github.com/open-webui/open-webui/commit/ff474936f81c921922cbb8718d3215c5cba36d23) refac: remove model param
- [`7ffd75b`](https://github.com/open-webui/open-webui/commit/7ffd75b991782c9a5fe315abd80e1e0fd096d10b) refac: black
### 📊 Changes
**1 file changed** (+244 additions, -364 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/main.py` (+244 -364)
</details>
### 📄 Description
Was going to add this with another PR to fix `__event_emitter__` in Functions but thought this needed to be addressed separately.
# Pull Request Checklist
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- Refactor main.py
### Changed
- Remove unused imports
- Remove unused declarations
- Remove unnecessary nesting for readability
- Refactor extra parameters into a separate loop
- Ensure all variables are bound
- Remove unused `model` parameter if `model` was overridden anyway
- Refactor `get_sorted_filters` into a separate function
Tested with both functions and tools. No changes in functionality expected.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/3734
Author: @michaelpoluektov
Created: 7/9/2024
Status: ✅ Merged
Merged: 7/9/2024
Merged by: @tjbck
Base:
dev← Head:refactor-main📝 Commits (10+)
afd7421Update main.py0951475Update main.py02f242ekeep title, task, function tags for pipelines24c7990revert not delete on pipe49b4211Merge branch 'dev' of https://github.com/open-webui/open-webui into devf9e3c47rebasee3e02e0refac: backend/main.pyd7dd901refac: remove nestingff47493refac: remove model param7ffd75brefac: black📊 Changes
1 file changed (+244 additions, -364 deletions)
View changed files
📝
backend/main.py(+244 -364)📄 Description
Was going to add this with another PR to fix
__event_emitter__in Functions but thought this needed to be addressed separately.Pull Request Checklist
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Changed
modelparameter ifmodelwas overridden anywayget_sorted_filtersinto a separate functionTested with both functions and tools. No changes in functionality expected.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.