github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 02:48:13 -05:00
Code Issues 1.1k Packages Projects Releases 126 Wiki Activity

[PR #1853] [MERGED] fix: modal should not close when dragging from inside of modal #36444

New Issue
Closed
opened 2026-04-25 10:18:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 10:18:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/1853
Author: @domsleee
Created: 4/29/2024
Status: ✅ Merged
Merged: 4/29/2024
Merged by: @tjbck

Base: dev ← Head: fix/modal-closing-on-mouseup

📝 Commits (1)

  • d4339fe fix: modal should not close when dragging from inside of modal

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/lib/components/common/Modal.svelte (+2 -2)

📄 Description

Description

Closes #1852.
Use mousedown event instead of click event to prevent modal window from closing on mouseup unexpectedly.

Fixed

  • Settings modal should not close when dragging from inside of modal

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/1853 **Author:** [@domsleee](https://github.com/domsleee) **Created:** 4/29/2024 **Status:** ✅ Merged **Merged:** 4/29/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/modal-closing-on-mouseup` --- ### 📝 Commits (1) - [`d4339fe`](https://github.com/open-webui/open-webui/commit/d4339fe769c9f990a9d0b28af47fc2eb06b50296) fix: modal should not close when dragging from inside of modal ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/common/Modal.svelte` (+2 -2) </details> ### 📄 Description ## Description Closes #1852. Use `mousedown` event instead of `click` event to prevent modal window from closing on `mouseup` unexpectedly. --- ### Fixed - Settings modal should not close when dragging from inside of modal --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 10:18:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#36444
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?