[GH-ISSUE #23902] feat: Update backend code to respect ruff linting rules configured in pyproject.toml #35631

New Issue

GiteaMirror · 2026-04-25T09:47:44-05:00

GiteaMirror commented

2026-04-25 09:47:44 -05:00

Originally created by @Samreay on GitHub (Apr 21, 2026).
Original GitHub issue: https://github.com/open-webui/open-webui/issues/23902

Check Existing Issues

I have searched for all existing open AND closed issues and discussions for similar requests. I have found none that is comparable to my request.

Verify Feature Scope

I have read through and understood the scope definition for feature requests in the Issues section. I believe my feature request meets the definition and belongs in the Issues section instead of the Discussions.

Problem Description

In https://github.com/open-webui/open-webui/discussions/22462 and https://github.com/open-webui/open-webui/pull/22576, the ruff formatter and linter was added to openwebui. However, only the formatter has been run, and the ruff linting raises numerous errors. The backend-lint workflow step is also disabled.

There is a pre-commit step with ruff fixing backend lint errors, but it doesnt seem to have been run (reports hundreds of error).

Would you be open to a PR which lints the code base?

Desired Solution you'd like

Someone saying "Sure, lint away!" so I dont create a large PR that doesnt go anywhere haha

Alternatives Considered

No response

Additional Context

No response

Originally created by @Samreay on GitHub (Apr 21, 2026). Original GitHub issue: https://github.com/open-webui/open-webui/issues/23902 ### Check Existing Issues - [x] I have searched for all existing **open AND closed** issues and discussions for similar requests. I have found none that is comparable to my request. ### Verify Feature Scope - [x] I have read through and understood the scope definition for feature requests in the Issues section. I believe my feature request meets the definition and belongs in the Issues section instead of the Discussions. ### Problem Description In https://github.com/open-webui/open-webui/discussions/22462 and https://github.com/open-webui/open-webui/pull/22576, the ruff formatter and linter was added to openwebui. However, only the formatter has been run, and the ruff linting raises numerous errors. The backend-lint workflow step is also disabled. There is a pre-commit step with ruff fixing backend lint errors, but it doesnt seem to have been run (reports hundreds of error). Would you be open to a PR which lints the code base? ### Desired Solution you'd like Someone saying "Sure, lint away!" so I dont create a large PR that doesnt go anywhere haha ### Alternatives Considered _No response_ ### Additional Context _No response_

GiteaMirror closed this issue

2026-04-25 09:47:44 -05:00

GiteaMirror commented

2026-04-25 09:47:45 -05:00

@pr-validator-bot commented on GitHub (Apr 21, 2026):

⚠️ Invalid Issue Title

Hey @Samreay, please provide a descriptive title for your issue. Titles that are empty, very short (under 10 characters), or generic (like "issue:" or "feat:") make it difficult for volunteer contributors to understand and triage issues.

Please update the title to reflect the content of your issue.

⚠️ Missing Issue Title Prefix

@Samreay, your issue title is missing a prefix (e.g., bug:, feat:, docs:).

Please update your issue title to include one of the following prefixes:

bug: Bug report or error you've encountered
feat: Feature request or enhancement suggestion
docs: Documentation issue or improvement request
question: Question about usage or functionality
help: Request for help or support

Example: bug: Login fails when using special characters in password

@pr-validator-bot commented on GitHub (Apr 21, 2026): # ⚠️ Invalid Issue Title Hey @Samreay, please provide a descriptive title for your issue. Titles that are empty, very short (under 10 characters), or generic (like "issue:" or "feat:") make it difficult for volunteer contributors to understand and triage issues. Please update the title to reflect the content of your issue. --- # ⚠️ Missing Issue Title Prefix @Samreay, your issue title is missing a prefix (e.g., `bug:`, `feat:`, `docs:`). Please update your issue title to include one of the following prefixes: - **bug**: Bug report or error you've encountered - **feat**: Feature request or enhancement suggestion - **docs**: Documentation issue or improvement request - **question**: Question about usage or functionality - **help**: Request for help or support Example: `bug: Login fails when using special characters in password`

GiteaMirror commented

2026-04-25 09:47:45 -05:00

@tjbck commented on GitHub (Apr 21, 2026):

Not a priority, we may eventually get to it.

@tjbck commented on GitHub (Apr 21, 2026): Not a priority, we may eventually get to it.

GiteaMirror commented

2026-04-25 09:47:46 -05:00

@Samreay commented on GitHub (Apr 21, 2026):

Right, that's why I was asking if you wanted me to do it and provide a PR on it, so it didn't have to shift development priorities. But if its not wanted / disruptive, all good. It might be good to remove the rules and precommit config then, because it means people setting up the repo for the first time get hit with thousands of errors in pre commit

@Samreay commented on GitHub (Apr 21, 2026): Right, that's why I was asking if you wanted me to do it and provide a PR on it, so it didn't have to shift development priorities. But if its not wanted / disruptive, all good. It might be good to remove the rules and precommit config then, because it means people setting up the repo for the first time get hit with thousands of errors in pre commit

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#35631