The ydoc:document:update handler only checked room membership, which read-only users satisfy via ydoc:document:join. This allowed read-only users to persist and broadcast Yjs updates to shared notes. Adds a write permission check before any update is stored or broadcast.
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/23624
**Author:** [@Classic298](https://github.com/Classic298)
**Created:** 4/12/2026
**Status:** ❌ Closed
**Base:** `dev` ← **Head:** `fix/ydoc-write-permission-check`
---
### 📝 Commits (2)
- [`402a033`](https://github.com/open-webui/open-webui/commit/402a0334a930a49fd62616a5661ae73c773b2488) fix: enforce write permission on ydoc document updates
- [`71d2bb4`](https://github.com/open-webui/open-webui/commit/71d2bb4fdbca6aadba930771abb287e86b74b924) merge: resolve conflicts with upstream async DB migration
### 📊 Changes
**2 files changed** (+106 additions, -23 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/main.py` (+2 -0)
📝 `backend/open_webui/socket/main.py` (+104 -23)
</details>
### 📄 Description
The ydoc:document:update handler only checked room membership, which read-only users satisfy via ydoc:document:join. This allowed read-only users to persist and broadcast Yjs updates to shared notes. Adds a write permission check before any update is stored or broadcast.
### Contributor License Agreement
<!--
🚨 DO NOT DELETE THE TEXT BELOW 🚨
Keep the "Contributor License Agreement" confirmation text intact.
Deleting it will trigger the CLA-Bot to INVALIDATE your PR.
Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA.
-->
- [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms.
> [!NOTE]
> Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/23624
Author: @Classic298
Created: 4/12/2026
Status: ❌ Closed
Base:
dev← Head:fix/ydoc-write-permission-check📝 Commits (2)
402a033fix: enforce write permission on ydoc document updates71d2bb4merge: resolve conflicts with upstream async DB migration📊 Changes
2 files changed (+106 additions, -23 deletions)
View changed files
📝
backend/open_webui/main.py(+2 -0)📝
backend/open_webui/socket/main.py(+104 -23)📄 Description
The ydoc:document:update handler only checked room membership, which read-only users satisfy via ydoc:document:join. This allowed read-only users to persist and broadcast Yjs updates to shared notes. Adds a write permission check before any update is stored or broadcast.
Contributor License Agreement
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.