github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-13 14:46:29 -05:00
Code Issues 1.5k Packages Projects Releases 129 Wiki Activity

[PR #23262] [CLOSED] fix: respect 'always expand details' setting for collapsible tool groups #27110

New Issue
Closed
opened 2026-04-20 06:52:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 06:52:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23262
Author: @karthik-idikuda
Created: 3/31/2026
Status: ❌ Closed

Base: dev ← Head: fix/expand-details-collapsible-groups

📝 Commits (1)

  • 72d6daf fix: respect 'always expand details' setting for collapsible tool groups

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 src/lib/components/chat/Messages/Markdown/ConsecutiveDetailsGroup.svelte (+1 -1)
📝 src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte (+2 -2)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch.
  • Description: Provided below.
  • Changelog: Included below.
  • Testing: Manually verified the fix works as intended.
  • Code review: Self-reviewed the changes.
  • Title Prefix: fix:

Changelog Entry

Description

Fixes #23255

When the "Always Expand Details" setting is enabled (Settings → Interface → Chat → Always Expand Details), collapsible tool call groups and standalone tool call details still start collapsed. This is because certain ToolCallDisplay components and the ConsecutiveDetailsGroup wrapper hardcode open={false} instead of reading from the user's settings store.

ConsecutiveDetailsGroup.svelte

  • Changed let open = false; to let open = $settings?.expandDetails ?? false;
  • The settings store was already imported — the initial open state now respects the user's preference while still allowing manual toggling.

MarkdownTokens.svelte

  • Changed open={false} → open={$settings?.expandDetails ?? false} for grouped ToolCallDisplay (inside ConsecutiveDetailsGroup)
  • Changed open={false} → open={$settings?.expandDetails ?? false} for standalone ToolCallDisplay (outside group)

Note: Collapsible components for non-tool-call details already correctly read $settings?.expandDetails — only ToolCallDisplay and the group wrapper were missing this.

Fixed

  • Fixed collapsible tool groups ignoring "Always Expand Details" setting (#23255)

Additional Information

  • Related to #21604 (original "expand details" feature)
  • The fix is minimal: 3 lines changed across 2 files, each changing false to $settings?.expandDetails ?? false

How to Test

  1. Enable Settings → Interface → Chat → Always Expand Details
  2. Send a message that triggers tool calls (e.g., web search)
  3. Before fix: Tool call groups appear collapsed despite the setting
  4. After fix: Tool call groups appear expanded, matching the user's preference

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23262 **Author:** [@karthik-idikuda](https://github.com/karthik-idikuda) **Created:** 3/31/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/expand-details-collapsible-groups` --- ### 📝 Commits (1) - [`72d6daf`](https://github.com/open-webui/open-webui/commit/72d6daf32dae9e436e04270b5b64e24dcec065ed) fix: respect 'always expand details' setting for collapsible tool groups ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/Markdown/ConsecutiveDetailsGroup.svelte` (+1 -1) 📝 `src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte` (+2 -2) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. - [x] **Description:** Provided below. - [x] **Changelog:** Included below. - [x] **Testing:** Manually verified the fix works as intended. - [x] **Code review:** Self-reviewed the changes. - [x] **Title Prefix:** `fix:` # Changelog Entry ### Description Fixes #23255 When the **"Always Expand Details"** setting is enabled (Settings → Interface → Chat → Always Expand Details), collapsible tool call groups and standalone tool call details still start collapsed. This is because certain `ToolCallDisplay` components and the `ConsecutiveDetailsGroup` wrapper hardcode `open={false}` instead of reading from the user's settings store. **`ConsecutiveDetailsGroup.svelte`** - Changed `let open = false;` to `let open = $settings?.expandDetails ?? false;` - The `settings` store was already imported — the initial open state now respects the user's preference while still allowing manual toggling. **`MarkdownTokens.svelte`** - Changed `open={false}` → `open={$settings?.expandDetails ?? false}` for grouped `ToolCallDisplay` (inside `ConsecutiveDetailsGroup`) - Changed `open={false}` → `open={$settings?.expandDetails ?? false}` for standalone `ToolCallDisplay` (outside group) Note: `Collapsible` components for non-tool-call details already correctly read `$settings?.expandDetails` — only `ToolCallDisplay` and the group wrapper were missing this. ### Fixed - Fixed collapsible tool groups ignoring "Always Expand Details" setting (#23255) --- ### Additional Information - Related to #21604 (original "expand details" feature) - The fix is minimal: 3 lines changed across 2 files, each changing `false` to `$settings?.expandDetails ?? false` ### How to Test 1. Enable **Settings → Interface → Chat → Always Expand Details** 2. Send a message that triggers tool calls (e.g., web search) 3. **Before fix**: Tool call groups appear collapsed despite the setting 4. **After fix**: Tool call groups appear expanded, matching the user's preference ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 06:52:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#27110
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?