[PR #22887] [CLOSED] fix: stop event bubbling on memory deletion #26912

Closed
opened 2026-04-20 06:46:10 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22887
Author: @silentoplayz
Created: 3/20/2026
Status: Closed

Base: devHead: fix/memory-deletion-event-bubbling


📝 Commits (1)

  • 7bac631 fix(ui): stop event bubbling on memory deletion

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/lib/components/chat/Settings/Personalization/ManageModal.svelte (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • fix: Bug fix or error correction

Changelog Entry

Description

  • Fixed an issue in the Memory Manage modal where deleting or editing a memory entry would also trigger the parent list item's click handler, opening the "Edit Memory" modal simultaneously. Added |stopPropagation to the Edit and Delete buttons in ManageModal.svelte.

Fixed

  • Event bubbling in the Memory Manage modal list items.

Additional Information

Screenshots or Videos

Before:

Image Image

After:

image

Manual Verification Performed

  1. Navigate to Settings > Personalization > Memory (Experimental) Manage.
  2. Click the Delete (trash can) icon for any memory entry.
  3. Verify that the memory is deleted (toast appear) and the Edit Memory modal does NOT open.
  4. Click the Edit (pencil) icon for any memory entry.
  5. Verify the modal opens correctly without any double-triggering issues.
  6. Click the list item itself (avoiding the buttons).
  7. Verify the Edit Memory modal opens as expected.

Contributor License Agreement


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22887 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 3/20/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/memory-deletion-event-bubbling` --- ### 📝 Commits (1) - [`7bac631`](https://github.com/open-webui/open-webui/commit/7bac631cd6c41d6081d402c1fe939b4d6464d8db) fix(ui): stop event bubbling on memory deletion ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/Personalization/ManageModal.svelte` (+2 -2) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description - Fixed an issue in the Memory Manage modal where deleting or editing a memory entry would also trigger the parent list item's click handler, opening the "Edit Memory" modal simultaneously. Added `|stopPropagation` to the Edit and Delete buttons in `ManageModal.svelte`. ### Fixed - Event bubbling in the Memory Manage modal list items. --- ### Additional Information - This prevents a ghost "Memory Not found" error that occurred when a user would inadvertently "Update" a memory that had just been deleted by the bubbling event. - This PR fixes [issue: Memory Deletion Unexpectedly Triggers Edit Modal Due to Event Bubbling](https://github.com/open-webui/open-webui/issues/22783). ### Screenshots or Videos #### Before: <img width="1988" height="1020" alt="Image" src="https://github.com/user-attachments/assets/9f13f88a-1e64-448e-977f-0bbb0a5499c1" /> <img width="1988" height="1020" alt="Image" src="https://github.com/user-attachments/assets/b14333f3-c9c0-428c-a4c6-fe34be52bcf7" /> #### After: <img width="1961" height="839" alt="image" src="https://github.com/user-attachments/assets/9f029b5a-b231-4637-b2e6-e14c3a138843" /> ### Manual Verification Performed 1. Navigate to **Settings** > **Personalization** > **Memory (Experimental) Manage**. 2. Click the **Delete** (trash can) icon for any memory entry. 3. Verify that the memory is deleted (toast appear) and the **Edit Memory** modal does NOT open. 4. Click the **Edit** (pencil) icon for any memory entry. 5. Verify the modal opens correctly without any double-triggering issues. 6. Click the list item itself (avoiding the buttons). 7. Verify the **Edit Memory** modal opens as expected. ### Contributor License Agreement - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 06:46:10 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#26912