github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #22854] [CLOSED] fix: close thread sidebar when parent message is deleted #26889

New Issue
Closed
opened 2026-04-20 06:45:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 06:45:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22854
Author: @alvinttang
Created: 3/19/2026
Status: ❌ Closed

Base: main ← Head: fix/thread-sidebar-orphan-on-delete

📝 Commits (1)

  • 75f893d fix: close thread sidebar when parent message is deleted

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/lib/components/channel/Channel.svelte (+5 -0)

📄 Description

Summary

  • Fixes the thread sidebar remaining open and interactable after the parent message is deleted, creating orphaned threads
  • Adds a check in the message:delete event handler in Channel.svelte to reset threadId to null when the deleted message matches the currently open thread's parent ID

Fixes #22781

Test plan

  • Open any channel and create a message with thread replies
  • Open the thread sidebar for that message
  • Delete the parent message
  • Verify the thread sidebar closes automatically
  • Verify deleting a non-thread message does not affect the open thread sidebar

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22854 **Author:** [@alvinttang](https://github.com/alvinttang) **Created:** 3/19/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/thread-sidebar-orphan-on-delete` --- ### 📝 Commits (1) - [`75f893d`](https://github.com/open-webui/open-webui/commit/75f893d49a54c5ccbd6d44ff97ebc029ba39ebb5) fix: close thread sidebar when parent message is deleted ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/channel/Channel.svelte` (+5 -0) </details> ### 📄 Description ## Summary - Fixes the thread sidebar remaining open and interactable after the parent message is deleted, creating orphaned threads - Adds a check in the `message:delete` event handler in `Channel.svelte` to reset `threadId` to `null` when the deleted message matches the currently open thread's parent ID Fixes #22781 ## Test plan - [ ] Open any channel and create a message with thread replies - [ ] Open the thread sidebar for that message - [ ] Delete the parent message - [ ] Verify the thread sidebar closes automatically - [ ] Verify deleting a non-thread message does not affect the open thread sidebar 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 06:45:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#26889
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?