github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 19:08:59 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #22852] [CLOSED] fix: prevent event bubbling on memory edit/delete buttons #26887

New Issue
Closed
opened 2026-04-20 06:45:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 06:45:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22852
Author: @futhgar
Created: 3/19/2026
Status: ❌ Closed

Base: dev ← Head: fix/memory-delete-event-bubbling

📝 Commits (1)

  • 122be0b fix: prevent event bubbling on memory edit/delete buttons

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/lib/components/chat/Settings/Personalization/ManageModal.svelte (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • fix: Bug fix or error correction

Changelog Entry

Description

  • Fix event bubbling issue in Memory ManageModal where clicking the Delete (or Edit) button on a memory entry causes the click event to propagate to the parent row's on:click handler, which opens the Edit Memory modal. This results in the memory being deleted while the Edit modal simultaneously opens for the now-deleted entry, leading to a 404 error if the user attempts to update.

Fixed

  • Memory deletion no longer unexpectedly opens the Edit Memory modal due to event bubbling from action buttons to the parent row click handler.
  • Memory edit button click no longer fires the parent row's click handler redundantly.

How it was fixed

Added Svelte's |stopPropagation event modifier to both the Edit and Delete button on:click handlers in ManageModal.svelte. This prevents the click event from bubbling up to the parent <div> element that has its own on:click handler for opening the edit modal.

This is a minimal, two-line change consistent with the existing pattern used throughout the codebase (e.g., FileItem.svelte, Sidebar/SearchInput.svelte, FilesModal.svelte).

Steps to reproduce (before fix)

  1. Navigate to Settings > Personalization
  2. Click Manage under Memory
  3. Click the Delete (trash can) icon on any memory entry
  4. Observe: memory is deleted, but the Edit Memory modal also opens
  5. Click Update in the ghost modal
  6. Observe: 404 error (Memory Not found)

After fix

Clicking Delete removes the memory and shows the success toast without opening the Edit modal.

Fixes #22783

Additional Information

  • No new dependencies
  • No documentation changes needed (internal UI behavior fix)
  • The |stopPropagation modifier is already used extensively across the codebase for similar parent-child click handler patterns

Contributor License Agreement

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22852 **Author:** [@futhgar](https://github.com/futhgar) **Created:** 3/19/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/memory-delete-event-bubbling` --- ### 📝 Commits (1) - [`122be0b`](https://github.com/open-webui/open-webui/commit/122be0b5cd11305b958e9b70e1d57ffc442e97c8) fix: prevent event bubbling on memory edit/delete buttons ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/Personalization/ManageModal.svelte` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description - Fix event bubbling issue in Memory ManageModal where clicking the Delete (or Edit) button on a memory entry causes the click event to propagate to the parent row's `on:click` handler, which opens the Edit Memory modal. This results in the memory being deleted while the Edit modal simultaneously opens for the now-deleted entry, leading to a 404 error if the user attempts to update. ### Fixed - Memory deletion no longer unexpectedly opens the Edit Memory modal due to event bubbling from action buttons to the parent row click handler. - Memory edit button click no longer fires the parent row's click handler redundantly. ### How it was fixed Added Svelte's `|stopPropagation` event modifier to both the Edit and Delete button `on:click` handlers in `ManageModal.svelte`. This prevents the click event from bubbling up to the parent `<div>` element that has its own `on:click` handler for opening the edit modal. This is a minimal, two-line change consistent with the existing pattern used throughout the codebase (e.g., `FileItem.svelte`, `Sidebar/SearchInput.svelte`, `FilesModal.svelte`). ### Steps to reproduce (before fix) 1. Navigate to **Settings > Personalization** 2. Click **Manage** under Memory 3. Click the **Delete** (trash can) icon on any memory entry 4. Observe: memory is deleted, but the Edit Memory modal also opens 5. Click **Update** in the ghost modal 6. Observe: 404 error (`Memory Not found`) ### After fix Clicking Delete removes the memory and shows the success toast without opening the Edit modal. Fixes #22783 --- ### Additional Information - No new dependencies - No documentation changes needed (internal UI behavior fix) - The `|stopPropagation` modifier is already used extensively across the codebase for similar parent-child click handler patterns ### Contributor License Agreement - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 06:45:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#26887
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?