github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #22418] [CLOSED] fix: replace bare except clauses with except Exception #26675

New Issue
Closed
opened 2026-04-20 06:38:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 06:38:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22418
Author: @gambletan
Created: 3/8/2026
Status: ❌ Closed

Base: dev ← Head: fix/bare-except-clauses

📝 Commits (10+)

📊 Changes

11 files changed (+17 additions, -17 deletions)

View changed files

📝 backend/open_webui/main.py (+2 -2)
📝 backend/open_webui/retrieval/loaders/external_document.py (+1 -1)
📝 backend/open_webui/retrieval/loaders/mineru.py (+3 -3)
📝 backend/open_webui/retrieval/vector/dbs/chroma.py (+1 -1)
📝 backend/open_webui/routers/chats.py (+1 -1)
📝 backend/open_webui/routers/configs.py (+1 -1)
📝 backend/open_webui/routers/pipelines.py (+2 -2)
📝 backend/open_webui/routers/retrieval.py (+1 -1)
📝 backend/open_webui/socket/main.py (+1 -1)
📝 backend/open_webui/utils/middleware.py (+3 -3)
📝 backend/open_webui/utils/oauth.py (+1 -1)

📄 Description

Summary

  • Replace all bare except: clauses with except Exception: across the backend codebase
  • Bare except: catches BaseException, including SystemExit and KeyboardInterrupt, which prevents clean shutdown and Ctrl+C signal handling
  • This change ensures system signals propagate correctly while still catching all actual errors

Files Changed

  • backend/open_webui/main.py
  • backend/open_webui/socket/main.py
  • backend/open_webui/utils/middleware.py
  • backend/open_webui/utils/oauth.py
  • backend/open_webui/routers/configs.py
  • backend/open_webui/routers/retrieval.py
  • backend/open_webui/routers/chats.py
  • backend/open_webui/routers/pipelines.py
  • backend/open_webui/retrieval/vector/dbs/chroma.py
  • backend/open_webui/retrieval/loaders/mineru.py
  • backend/open_webui/retrieval/loaders/external_document.py

Test plan

  • Verify existing tests pass
  • Verify Ctrl+C cleanly shuts down the server
  • Verify error handling behavior is unchanged for actual exceptions

CLA

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22418 **Author:** [@gambletan](https://github.com/gambletan) **Created:** 3/8/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/bare-except-clauses` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **11 files changed** (+17 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/main.py` (+2 -2) 📝 `backend/open_webui/retrieval/loaders/external_document.py` (+1 -1) 📝 `backend/open_webui/retrieval/loaders/mineru.py` (+3 -3) 📝 `backend/open_webui/retrieval/vector/dbs/chroma.py` (+1 -1) 📝 `backend/open_webui/routers/chats.py` (+1 -1) 📝 `backend/open_webui/routers/configs.py` (+1 -1) 📝 `backend/open_webui/routers/pipelines.py` (+2 -2) 📝 `backend/open_webui/routers/retrieval.py` (+1 -1) 📝 `backend/open_webui/socket/main.py` (+1 -1) 📝 `backend/open_webui/utils/middleware.py` (+3 -3) 📝 `backend/open_webui/utils/oauth.py` (+1 -1) </details> ### 📄 Description ## Summary - Replace all bare `except:` clauses with `except Exception:` across the backend codebase - Bare `except:` catches `BaseException`, including `SystemExit` and `KeyboardInterrupt`, which prevents clean shutdown and Ctrl+C signal handling - This change ensures system signals propagate correctly while still catching all actual errors ## Files Changed - `backend/open_webui/main.py` - `backend/open_webui/socket/main.py` - `backend/open_webui/utils/middleware.py` - `backend/open_webui/utils/oauth.py` - `backend/open_webui/routers/configs.py` - `backend/open_webui/routers/retrieval.py` - `backend/open_webui/routers/chats.py` - `backend/open_webui/routers/pipelines.py` - `backend/open_webui/retrieval/vector/dbs/chroma.py` - `backend/open_webui/retrieval/loaders/mineru.py` - `backend/open_webui/retrieval/loaders/external_document.py` ## Test plan - [ ] Verify existing tests pass - [ ] Verify Ctrl+C cleanly shuts down the server - [ ] Verify error handling behavior is unchanged for actual exceptions ## CLA - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 06:38:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#26675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?