github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #22294] [CLOSED] fix: reset tool selection when switching models #26595

New Issue
Closed
opened 2026-04-20 06:35:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 06:35:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22294
Author: @zspirit
Created: 3/6/2026
Status: ❌ Closed

Base: dev ← Head: fix/tool-selection-on-model-switch

📝 Commits (10+)

📊 Changes

1 file changed (+4 additions, -6 deletions)

View changed files

📝 src/lib/components/chat/Chat.svelte (+4 -6)

📄 Description

Pull Request Checklist

  • Target branch: dev
  • Description: See below
  • Testing: Manually verified — see test evidence below
  • Agentic AI Code: This PR has gone through human review and manual testing
  • Code review: Self-reviewed

Changelog Entry

Description

  • Fix tool selection not being properly reset when switching models in chat (fixes #14157)

Fixed

  • When switching to a model with configured tools, only that model's tools are now selected (removed unnecessary new Set wrapping)
  • When switching to a model with no configured tools and no user defaults, selectedToolIds is now cleared entirely instead of preserving tools from the previous model

Testing Evidence

Setup: Created 2 tools (Weather Tool, Calculator Tool) and 3 model presets:

  • Test Model X — configured with Weather Tool
  • Test Model Y — configured with Calculator Tool
  • Test Model Z — configured with NO tools

Test 1 — Select Model X: Wrench icon shows "1" (Weather Tool) ✅
Test 2 — Switch to Model Y: Wrench shows "1" (Calculator Tool only, Weather cleared) ✅
Test 3 — Switch to Model Z: Wrench icon gone entirely (all tools cleared) ✅

Screenshots posted in PR comments.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22294 **Author:** [@zspirit](https://github.com/zspirit) **Created:** 3/6/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/tool-selection-on-model-switch` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **1 file changed** (+4 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Chat.svelte` (+4 -6) </details> ### 📄 Description # Pull Request Checklist - [x] **Target branch:** `dev` - [x] **Description:** See below - [x] **Testing:** Manually verified — see test evidence below - [x] **Agentic AI Code:** This PR has gone through human review and manual testing - [x] **Code review:** Self-reviewed # Changelog Entry ### Description - Fix tool selection not being properly reset when switching models in chat (fixes #14157) ### Fixed - When switching to a model with configured tools, only that model's tools are now selected (removed unnecessary `new Set` wrapping) - When switching to a model with no configured tools and no user defaults, `selectedToolIds` is now cleared entirely instead of preserving tools from the previous model ### Testing Evidence **Setup:** Created 2 tools (Weather Tool, Calculator Tool) and 3 model presets: - Test Model X — configured with Weather Tool - Test Model Y — configured with Calculator Tool - Test Model Z — configured with NO tools **Test 1 — Select Model X:** Wrench icon shows "1" (Weather Tool) ✅ **Test 2 — Switch to Model Y:** Wrench shows "1" (Calculator Tool only, Weather cleared) ✅ **Test 3 — Switch to Model Z:** Wrench icon gone entirely (all tools cleared) ✅ Screenshots posted in PR comments. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 06:35:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#26595
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?