## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21897 **Author:** [@fama-05](https://github.com/fama-05) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 3/8/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`59a0dd0`](https://github.com/open-webui/open-webui/commit/59a0dd0cbba01746da78ed03b80d9820ae9e95d8) Update Citations.svelte ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/Citations.svelte` (+3 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** No user-facing documentation changes needed. - [ ] **Dependencies:** No changes on dependencies - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description - Fixed a failure similar to #21730 in the web‑search-sources where favicons could not be displayed because the search backend runs in an isolated environment. The code now detects missing external icon resources and falls back to a default open-webui favicon. ### Added - Added `on:error` handler to `<img />` for sources from websearch. Uses the open-webui favicon as fallback in `Citations.svelte`. ### Fixed - Resolved a problem in Firefox where the `alt` text displayed for a broken image overflow its container. --- ### Additional Information - its similar to #21730 - Prevent Firefox from showing overflowing `alt` text when an avatar fails to load by adding an `on:error` handler that swaps in a fallback icon. ### Screenshots or Videos ### before <img width="1123" height="498" alt="screen2" src="https://github.com/user-attachments/assets/511e2f0e-3e5a-4c0d-aba3-893743219b4f" /> ### after <img width="1138" height="489" alt="screen1" src="https://github.com/user-attachments/assets/424344aa-e909-4d5f-8e50-878771aeb687" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror commented

2026-04-20 06:26:27 -05:00

Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21897
Author: @fama-05
Created: 2/26/2026
Status: ✅ Merged
Merged: 3/8/2026
Merged by: @tjbck

Base: dev ← Head: dev

📝 Commits (1)

59a0dd0 Update Citations.svelte

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 src/lib/components/chat/Messages/Citations.svelte (+3 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: No user-facing documentation changes needed.
Dependencies: No changes on dependencies
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- fix: Bug fix or error correction

Changelog Entry

Description

Fixed a failure similar to #21730 in the web‑search-sources where favicons could not be displayed because the search backend runs in an isolated environment. The code now detects missing external icon resources and falls back to a default open-webui favicon.

Added

Added on:error handler to <img /> for sources from websearch. Uses the open-webui favicon as fallback in Citations.svelte.

Fixed

Resolved a problem in Firefox where the alt text displayed for a broken image overflow its container.

Additional Information

its similar to #21730
- Prevent Firefox from showing overflowing alt text when an avatar fails to load by adding an on:error handler that swaps in a fallback icon.

Screenshots or Videos

before

after

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-20 06:26:27 -05:00

GiteaMirror closed this issue

[PR #21897] [MERGED] fix: Fallback for missing favicons in web‑search sources #26328