[PR #21883] [CLOSED] perf: memoize sourceIds computation in ContentRenderer #26320

New Issue

GiteaMirror · 2026-04-20T06:26:16-05:00

GiteaMirror commented

2026-04-20 06:26:16 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21883
Author: @Classic298
Created: 2/25/2026
Status: ❌ Closed

Base: dev ← Head: perf/memoize-sourceids

📝 Commits (1)

63c512b perf: memoize sourceIds computation in ContentRenderer

📊 Changes

1 file changed (+35 additions, -30 deletions)

View changed files

📝 src/lib/components/chat/Messages/ContentRenderer.svelte (+35 -30)

📄 Description

The sourceIds array was computed inline in the template via a complex reduce/forEach/filter chain. This meant it re-ran on every component re-render, including every streaming content update, even though it only depends on sources and model which rarely change during streaming. Move the computation to a reactive variable so Svelte only recalculates it when its actual dependencies change.

this is a completely invisible change - free lunch

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21883 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 2/25/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `perf/memoize-sourceids` --- ### 📝 Commits (1) - [`63c512b`](https://github.com/open-webui/open-webui/commit/63c512bb98529fec85fa68f4bd729f7a1800d4c4) perf: memoize sourceIds computation in ContentRenderer ### 📊 Changes **1 file changed** (+35 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/ContentRenderer.svelte` (+35 -30) </details> ### 📄 Description The sourceIds array was computed inline in the template via a complex reduce/forEach/filter chain. This meant it re-ran on every component re-render, including every streaming content update, even though it only depends on sources and model which rarely change during streaming. Move the computation to a reactive variable so Svelte only recalculates it when its actual dependencies change. <ins>**this is a completely invisible change - free lunch**</ins> ### Contributor License Agreement  By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 06:26:16 -05:00

GiteaMirror closed this issue

2026-04-20 06:26:17 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#26320