## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21505 **Author:** [@aviu16](https://github.com/aviu16) **Created:** 2/17/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `codex/openwebui-none-identity` --- ### 📝 Commits (2) - [`e6a1a56`](https://github.com/open-webui/open-webui/commit/e6a1a56b8d165ee23b0a566bf5eda00626bb653d) fix: use identity checks for None in socket and title paths - [`e51d29d`](https://github.com/open-webui/open-webui/commit/e51d29df9cfc2efaec93cc3e34a788c177f8378f) fix: limit PR scope to socket None-check path ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/socket/main.py` (+1 -1) </details> ### 📄 Description # Pull Request Checklist - [x] **Target branch:** Verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [ ] **Changelog:** Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description. - [ ] **Documentation:** Add docs in Open WebUI Docs Repository. - [ ] **Dependencies:** No new dependencies. - [x] **Testing:** Performed manual checks and syntax checks for touched file. - [x] **Code Review:** Changes were manually reviewed and validated before submission. - [x] **Code review:** Self-reviewed. - [x] **Design & Architecture:** No architecture changes. - [x] **Git Hygiene:** Atomic fix with only relevant changes. - [x] **Title Prefix:** Uses `fix:`. # Changelog Entry ### Description - Replace `== None` with `is None` in the socket event data type check. - This avoids equality override edge cases and follows Python singleton comparison best practices. ### Added - None. ### Changed - `backend/open_webui/socket/main.py`: `data.get("type") is None` ### Deprecated - None. ### Removed - None. ### Fixed - Uses identity comparison for `None` in socket event fallback logic. ### Security - None. ### Breaking Changes - **BREAKING CHANGE**: None. --- ### Additional Information - Narrowed scope to a single call site for atomic review. ### Screenshots or Videos - N/A (backend-only conditional check). ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror commented

2026-04-20 06:20:02 -05:00

Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21505
Author: @aviu16
Created: 2/17/2026
Status: ❌ Closed

Base: dev ← Head: codex/openwebui-none-identity

📝 Commits (2)

e6a1a56 fix: use identity checks for None in socket and title paths
e51d29d fix: limit PR scope to socket None-check path

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/socket/main.py (+1 -1)

📄 Description

Pull Request Checklist

Target branch: Verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Add docs in Open WebUI Docs Repository.
Dependencies: No new dependencies.
Testing: Performed manual checks and syntax checks for touched file.
Code Review: Changes were manually reviewed and validated before submission.
Code review: Self-reviewed.
Design & Architecture: No architecture changes.
Git Hygiene: Atomic fix with only relevant changes.
Title Prefix: Uses fix:.

Changelog Entry

Description

Replace == None with is None in the socket event data type check.
This avoids equality override edge cases and follows Python singleton comparison best practices.

Added

None.

Changed

backend/open_webui/socket/main.py: data.get("type") is None

Deprecated

Removed

Fixed

Uses identity comparison for None in socket event fallback logic.

Security

Breaking Changes

BREAKING CHANGE: None.

Additional Information

Narrowed scope to a single call site for atomic review.

Screenshots or Videos

N/A (backend-only conditional check).

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-20 06:20:02 -05:00

GiteaMirror closed this issue

2026-04-20 06:20:04 -05:00

[PR #21505] [CLOSED] fix: use is None in socket event type check #26109