[PR #21144] [CLOSED] enh: preserve full-context knowledge files with native function calling #25948

New Issue

GiteaMirror · 2026-04-20T06:13:39-05:00

GiteaMirror commented

2026-04-20 06:13:39 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21144
Author: @jimbo-p
Created: 2/4/2026
Status: ❌ Closed

Base: dev ← Head: bugfix/full-context-mode-for-model-attachments

📝 Commits (2)

a904d93 Fix: Proper handling of full-context vs searchable file attachments with native tools
136664f Merge branch 'dev' into bugfix/full-context-mode-for-model-attachments

📊 Changes

4 files changed (+166 additions, -90 deletions)

View changed files

📝 backend/open_webui/tools/builtin.py (+102 -48)
📝 backend/open_webui/utils/middleware.py (+49 -35)
📝 backend/open_webui/utils/tools.py (+11 -5)
📝 src/lib/components/workspace/Models/ModelEditor.svelte (+4 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Enables full context injection when native tool calling is enabled. For files or knowledge bases (KB) that are attached to a model, clicking the file or KB and toggling 'Using Entire Document' now properly injects the full context of that file or KB into the message and removes the files / KBs from being included in the native query_knowledge_files function. This functionality was present for files / KBs attached to chats directly but was not enabled for files / KBs attached to models.

Added

NA

Changed

middleware.py: Full-context files now bypass RAG and inject directly into the conversation regardless of function calling mode; non-full-context files continue to use RAG when native FC is disabled
ModelEditor.svelte: Preserves the context property when converting legacy knowledge items
builtin.py: Skips full-context files in query_knowledge_files to prevent redundant searching (content already in conversation)

Deprecated

NA

Removed

NA

Fixed

NA

Security

NA

Breaking Changes

BREAKING CHANGE: NA

Additional Information

Discussed in [PR #2621] [CLOSED] Janine docs (#21051)
Also mentioned in [PR #2873] [MERGED] i18n: Added missing i18n keys for the pending overlay and other pages. (#21122)
Also mentioned in [PR #3022] [CLOSED] feat: openai endpoint should respect user's settings (#21164)

Screenshots or Videos

Builtin tools enabled for all screenshots

Open WebUI 0.7.2 (main) - Example of how turn on 'Using Entire Document' is not doing anything in current OWUI version with Builtin Tools checked. Token counts remain near identical but the document at hand is ~115k tokens in size.

Open WebUI 0.7.2 (PR) - 'Using Entire Document' now properly injects full context into message.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21144 **Author:** [@jimbo-p](https://github.com/jimbo-p) **Created:** 2/4/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `bugfix/full-context-mode-for-model-attachments` --- ### 📝 Commits (2) - [`a904d93`](https://github.com/open-webui/open-webui/commit/a904d933bd33373ab57b2dffdc028c03881faac5) Fix: Proper handling of full-context vs searchable file attachments with native tools - [`136664f`](https://github.com/open-webui/open-webui/commit/136664fbb7b975b57569936feb3d6f873ef2424e) Merge branch 'dev' into bugfix/full-context-mode-for-model-attachments ### 📊 Changes **4 files changed** (+166 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/tools/builtin.py` (+102 -48) 📝 `backend/open_webui/utils/middleware.py` (+49 -35) 📝 `backend/open_webui/utils/tools.py` (+11 -5) 📝 `src/lib/components/workspace/Models/ModelEditor.svelte` (+4 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Enables full context injection when native tool calling is enabled. For files or knowledge bases (KB) that are attached to a model, clicking the file or KB and toggling 'Using Entire Document' now properly injects the full context of that file or KB into the message and removes the files / KBs from being included in the native query_knowledge_files function. This functionality was present for files / KBs attached to chats directly but was not enabled for files / KBs attached to models. ### Added - NA ### Changed - `middleware.py`: Full-context files now bypass RAG and inject directly into the conversation regardless of function calling mode; non-full-context files continue to use RAG when native FC is disabled - `ModelEditor.svelte`: Preserves the `context` property when converting legacy knowledge items - `builtin.py`: Skips full-context files in `query_knowledge_files` to prevent redundant searching (content already in conversation) ### Deprecated - NA ### Removed - NA ### Fixed - NA ### Security - NA ### Breaking Changes - **BREAKING CHANGE**: NA --- ### Additional Information - Discussed in #21051 - Also mentioned in #21122 - Also mentioned in #21164 ### Screenshots or Videos Builtin tools enabled for all screenshots Open WebUI 0.7.2 (main) - Example of how turn on 'Using Entire Document' is not doing anything in current OWUI version with Builtin Tools checked. Token counts remain near identical but the document at hand is ~115k tokens in size. <img width="986" height="76" alt="image" src="https://github.com/user-attachments/assets/412db70f-4b82-4e4f-8c80-7e2c202e8f76" /> <img width="1307" height="656" alt="image" src="https://github.com/user-attachments/assets/f1e31e01-cb05-4064-a99c-8d899a0e52d7" /> <img width="991" height="94" alt="image" src="https://github.com/user-attachments/assets/ef6da7aa-0e62-4a05-8692-7e58c3d9d42f" /> <img width="1299" height="670" alt="image" src="https://github.com/user-attachments/assets/fe7d9651-68de-408e-8af3-4acd1d2b3c6f" /> Open WebUI 0.7.2 (PR) - 'Using Entire Document' now properly injects full context into message. <img width="986" height="76" alt="image" src="https://github.com/user-attachments/assets/a481ea1d-f56c-4d05-b70c-015016e84109" /> <img width="1463" height="600" alt="image" src="https://github.com/user-attachments/assets/cda46f9b-221e-48a4-8ca6-42b716349043" /> <img width="991" height="94" alt="image" src="https://github.com/user-attachments/assets/132cb9e1-7268-4ab8-9286-d6f9b089c383" /> <img width="1464" height="650" alt="image" src="https://github.com/user-attachments/assets/15ff272c-10b7-4b46-9a71-66d1d57e31ee" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 06:13:39 -05:00

GiteaMirror closed this issue

2026-04-20 06:13:41 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#25948