mirror of
https://github.com/open-webui/open-webui.git
synced 2026-05-06 10:58:17 -05:00
[PR #21071] [CLOSED] fix: AttributeError in citation parser when tool returns error #25912
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/open-webui#25912
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/21071
Author: @bennixview
Created: 1/31/2026
Status: ❌ Closed
Base:
dev← Head:fix/search-web-error-handling📝 Commits (10+)
fe6783cMerge pull request #19030 from open-webui/devfc05e0aMerge pull request #19405 from open-webui/deve3faec6Merge pull request #19416 from open-webui/dev9899293Merge pull request #19448 from open-webui/dev140605eMerge pull request #19462 from open-webui/dev6f1486fMerge pull request #19466 from open-webui/devd95f533Merge pull request #19729 from open-webui/deva7271530.6.43 (#20093)6adde20Merge pull request #20394 from open-webui/devf9b0534Merge pull request #20522 from open-webui/dev📊 Changes
2 files changed (+111 additions, -4 deletions)
View changed files
➕
backend/open_webui/test/util/test_middleware.py(+102 -0)📝
backend/open_webui/utils/middleware.py(+9 -4)📄 Description
When builtin tools fail, they return {"error": "..."} instead of their normal response format. The citation parser in middleware.py was not handling this case, causing AttributeError when iterating over error dicts (e.g., search_web expects a list).
Fix: Add generic error detection at the start of
get_citation_source_from_tool_result that checks for {"error": ...} pattern and returns empty list. Also refactored to parse JSON once and reuse the result.
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.
This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.
Before submitting, make sure you've checked the following:
devbranch. Not targeting thedevbranch will lead to immediate closure of the PR.When builtin tools fail, they return {"error": "..."} instead of their normal response format. The citation parser in middleware.py was not handling this case, causing AttributeError when iterating over error dicts (e.g., search_web expects a list).
Fix: Add generic error detection at the start of
get_citation_source_from_tool_result that checks for {"error": ...} pattern and returns empty list. Also refactored to parse JSON once and reuse the result.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: not needed
Dependencies: no new deps
Testing: added new test in test/util/test_middleware.py
Agentic AI Code: I run the new tests locally
Code review: yes
Title Prefix: done
Changelog Entry
Description
When builtin tools fail, they return {"error": "..."} instead of their normal response format. The citation parser in middleware.py was not handling this case, causing AttributeError when iterating over error dicts (e.g., search_web expects a list).
Fix: Add generic error detection at the start of
get_citation_source_from_tool_result that checks for {"error": ...} pattern and returns empty list. Also refactored to parse JSON once and reuse the result.
Added
new test in test/util/test_middleware.py
Changed
Add generic error detection at the start of
get_citation_source_from_tool_result that checks for {"error": ...} pattern and returns empty list. Also refactored to parse JSON once and reuse the result.
Deprecated
none
Removed
none
Fixed
Add generic error detection at the start of
get_citation_source_from_tool_result that checks for {"error": ...} pattern and returns empty list. Also refactored to parse JSON once and reuse the result.
Security
none
Breaking Changes
none
Additional Information
Screenshots or Videos
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.