github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #21065] [CLOSED] fix: web search not working in native FC mode when builtin_tools is disabled #25910

New Issue
Closed
opened 2026-04-20 06:12:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 06:12:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21065
Author: @ShikaiChen
Created: 1/31/2026
Status: ❌ Closed

Base: dev ← Head: fix/web-search-native-fc-decoupling

📝 Commits (10+)

📊 Changes

1 file changed (+21 additions, -0 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+21 -0)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch.
  • Description: Provided below.
  • Changelog: Included below.
  • Documentation: No documentation changes needed.
  • Dependencies: No new dependencies.
  • Testing: Manually verified all four capability combinations.
  • Agentic AI Code: This PR has gone through human review and manual testing.
  • Code review: Self-reviewed.
  • Title Prefix: fix:

Changelog Entry

Description

Relates to #20549

When builtin_tools capability is disabled on a model (e.g. to prevent builtin tools from being injected into API calls, as described in #20549), the entire get_builtin_tools() call is skipped in native function calling mode. This also disables web search, even when ENABLE_WEB_SEARCH=True and the model has web_search capability enabled.

This PR adds an elif fallback that injects only search_web and fetch_url tools when builtin_tools is off but web search should be available.

Added

  • Fallback path in middleware.py to inject web search tools (search_web, fetch_url) in native FC mode when builtin_tools is disabled but web search is enabled

Changed

  • N/A

Deprecated

  • N/A

Removed

  • N/A

Fixed

  • Web search now works in native function calling mode even when model builtin_tools capability is disabled, as long as ENABLE_WEB_SEARCH is enabled globally and the model has web_search capability

Security

  • N/A

Breaking Changes

  • N/A

Additional Information

Behavior matrix:

builtin_tools web_search Result
ON ON All tools injected (unchanged)
ON OFF All tools injected (unchanged, WIP per #20595)
OFF ON Only web search tools injected (FIXED)
OFF OFF No tools injected (unchanged)
non-native FC any RAG path (unaffected)

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21065 **Author:** [@ShikaiChen](https://github.com/ShikaiChen) **Created:** 1/31/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/web-search-native-fc-decoupling` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **1 file changed** (+21 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+21 -0) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. - [x] **Description:** Provided below. - [x] **Changelog:** Included below. - [ ] **Documentation:** No documentation changes needed. - [x] **Dependencies:** No new dependencies. - [x] **Testing:** Manually verified all four capability combinations. - [x] **Agentic AI Code:** This PR has gone through human review and manual testing. - [x] **Code review:** Self-reviewed. - [x] **Title Prefix:** `fix:` # Changelog Entry ### Description Relates to #20549 When `builtin_tools` capability is disabled on a model (e.g. to prevent builtin tools from being injected into API calls, as described in #20549), the entire `get_builtin_tools()` call is skipped in native function calling mode. This also disables web search, even when `ENABLE_WEB_SEARCH=True` and the model has `web_search` capability enabled. This PR adds an `elif` fallback that injects only `search_web` and `fetch_url` tools when `builtin_tools` is off but web search should be available. ### Added - Fallback path in `middleware.py` to inject web search tools (`search_web`, `fetch_url`) in native FC mode when `builtin_tools` is disabled but web search is enabled ### Changed - N/A ### Deprecated - N/A ### Removed - N/A ### Fixed - Web search now works in native function calling mode even when model `builtin_tools` capability is disabled, as long as `ENABLE_WEB_SEARCH` is enabled globally and the model has `web_search` capability ### Security - N/A ### Breaking Changes - N/A --- ### Additional Information - **File changed:** `backend/open_webui/utils/middleware.py` — 22 lines added (pure addition, zero existing lines modified) - Relates to #20549 **Behavior matrix:** | builtin_tools | web_search | Result | |:---:|:---:|---| | ON | ON | All tools injected (unchanged) | | ON | OFF | All tools injected (unchanged, WIP per #20595) | | **OFF** | **ON** | **Only web search tools injected (FIXED)** | | OFF | OFF | No tools injected (unchanged) | | non-native FC | any | RAG path (unaffected) | ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 06:12:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#25910
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?