[PR #21002] [CLOSED] perf: resolve N+1 query in models list access control check #25876

New Issue

GiteaMirror · 2026-04-20T06:10:38-05:00

GiteaMirror commented

2026-04-20 06:10:38 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21002
Author: @Classic298
Created: 1/28/2026
Status: ❌ Closed

Base: dev ← Head: group-check-n+1

📝 Commits (1)

0a383ca fix: resolve N+1 query in models list access control check

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/models.py (+6 -1)

📄 Description

Summary

Eliminates N+1 database query in the get_models endpoint (/list). Previously, the has_access function would query the database for user groups on each model in the list.

Changes

Pre-compute user_group_ids once from the already-fetched groups (which were being fetched anyway for the filter), then pass to has_access via the user_group_ids parameter.

Performance Impact

Before: N+1 queries - Groups.get_groups_by_member_id called once per model
After: 1 query total - reuses the groups already fetched for filter construction
The has_access function already supported the user_group_ids parameter to skip the DB lookup, it just wasn't being used here.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21002 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 1/28/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `group-check-n+1` --- ### 📝 Commits (1) - [`0a383ca`](https://github.com/open-webui/open-webui/commit/0a383ca78ab4d5da6acff7350b5fdaf4c820b0a7) fix: resolve N+1 query in models list access control check ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/models.py` (+6 -1) </details> ### 📄 Description ## Summary Eliminates N+1 database query in the get_models endpoint (/list). Previously, the has_access function would query the database for user groups on each model in the list. ## Changes Pre-compute user_group_ids once from the already-fetched groups (which were being fetched anyway for the filter), then pass to has_access via the user_group_ids parameter. ## Performance Impact Before: N+1 queries - Groups.get_groups_by_member_id called once per model After: 1 query total - reuses the groups already fetched for filter construction The has_access function already supported the user_group_ids parameter to skip the DB lookup, it just wasn't being used here. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 06:10:38 -05:00

GiteaMirror closed this issue

2026-04-20 06:10:39 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#25876