[PR #20776] [CLOSED] fix: Aggregate default tools from all selected models in chats #25778

New Issue

GiteaMirror · 2026-04-20T06:07:14-05:00

GiteaMirror commented

2026-04-20 06:07:14 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20776
Author: @silentoplayz
Created: 1/18/2026
Status: ❌ Closed

Base: dev ← Head: fix/tool-defaults-multi-model-chats

📝 Commits (1)

cda3d80 fix: Aggregate default tools from all selected models in chats

📊 Changes

1 file changed (+52 additions, -27 deletions)

View changed files

📝 src/lib/components/chat/Chat.svelte (+52 -27)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Issue

When the same model (or multiple models) are added to a chat, tools that should be enabled by default get toggled off. The setDefaults() function exits early when selectedModels.length !== 1, so defaults are never set for multi-model chats.

Description

Fix tool defaults not being applied when multiple models are selected in a chat. The setDefaults() function previously exited early when selectedModels.length !== 1, preventing default tools from being set for multi-model chats.

Fixed

src/lib/components/chat/Chat.svelte: Modified setDefaults() to aggregate toolIds, filterIds, and features from ALL selected models instead of only the first model

Additional Information

Problem: When adding the same model multiple times (or multiple different models) to a chat, tools that should be enabled by default were not being set because setDefaults() exited early for multi-model scenarios
Solution: Aggregate defaults from all selected models using Sets to avoid duplicates
Features only enabled if model has capability AND feature is in defaultFeatureIds
This ensures default tools set at the model level aren't ignored when adding or removing models from the model selector in a chat
Tested locally and working as expected

Testing Guide: Tool Defaults for Multi-Model Chats

Add a model with tools enabled by default to a chat → tools enabled as configured
Add the same model again (duplicate) → tools remain enabled
Add a 3rd instance of the same model (duplicate) → tools remain enabled
Add 2 different models (both with tools) with different default tool configurations → all tools from both models enabled
Add model without default tools → no tools enabled

Expected Behavior

Scenario	Expected Result
Add 1 model with default tools	Tools enabled as configured in model settings
Add same model 2nd time	Tools remain enabled (no toggling off)
Add same model 3rd time	Tools remain enabled
Add 2 different models (both with tools)	All tools from both models enabled
Add 2 models (only 1 has tools)	Only that model's tools enabled
Add model without default tools	No tools enabled
Remove all duplicate models	Tools reflect single remaining model

Screenshots or Videos

BEFORE

Add the same model again (duplicate) → tools from model are toggled off
Add 2 different models (both with tools) → tools from model are toggled off

AFTER

Add the same model again (duplicate) → tools remain enabled
Add 2 different models (both with tools) → all default tools from both models enabled

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20776 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 1/18/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/tool-defaults-multi-model-chats` --- ### 📝 Commits (1) - [`cda3d80`](https://github.com/open-webui/open-webui/commit/cda3d80a74155fa417d8733d5ab6af6c2e5e9170) fix: Aggregate default tools from all selected models in chats ### 📊 Changes **1 file changed** (+52 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Chat.svelte` (+52 -27) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Issue - When the same model (or multiple models) are added to a chat, tools that should be enabled by default get toggled off. The `setDefaults()` function exits early when `selectedModels.length !== 1`, so defaults are never set for multi-model chats. ### Description - Fix tool defaults not being applied when multiple models are selected in a chat. The `setDefaults()` function previously exited early when `selectedModels.length !== 1`, preventing default tools from being set for multi-model chats. ### Fixed - `src/lib/components/chat/Chat.svelte`: Modified `setDefaults()` to aggregate toolIds, filterIds, and features from ALL selected models instead of only the first model --- ### Additional Information - **Problem:** When adding the same model multiple times (or multiple different models) to a chat, tools that should be enabled by default were not being set because `setDefaults()` exited early for multi-model scenarios - **Solution:** Aggregate defaults from all selected models using Sets to avoid duplicates - Features only enabled if model has capability AND feature is in `defaultFeatureIds` - This ensures default tools set at the model level aren't ignored when adding or removing models from the model selector in a chat - Tested locally and working as expected ### Testing Guide: Tool Defaults for Multi-Model Chats - Add a model with tools enabled by default to a chat → tools enabled as configured - Add the same model again (duplicate) → tools remain enabled - Add a 3rd instance of the same model (duplicate) → tools remain enabled - Add 2 different models (both with tools) with different default tool configurations → all tools from both models enabled - Add model without default tools → no tools enabled ### Expected Behavior | Scenario | Expected Result | |---|---| | Add 1 model with default tools | Tools enabled as configured in model settings | | Add same model 2nd time | Tools remain enabled (no toggling off) | | Add same model 3rd time | Tools remain enabled | | Add 2 different models (both with tools) | All tools from both models enabled | | Add 2 models (only 1 has tools) | Only that model's tools enabled | | Add model without default tools | No tools enabled | | Remove all duplicate models | Tools reflect single remaining model | ### Screenshots or Videos ### BEFORE - Add the same model again (duplicate) → tools from model are toggled off - Add 2 different models (both with tools) → tools from model are toggled off <img width="2557" height="1280" alt="image" src="https://github.com/user-attachments/assets/7f60b28e-d9c4-4ce3-bd07-127d5c345b49" /> ### AFTER - Add the same model again (duplicate) → tools remain enabled - Add 2 different models (both with tools) → all default tools from both models enabled <img width="2557" height="1280" alt="image" src="https://github.com/user-attachments/assets/d40738b0-01bb-42df-b877-b7fa420e4ce2" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 06:07:14 -05:00

GiteaMirror closed this issue

2026-04-20 06:07:15 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#25778