[PR #20321] [CLOSED] fix: check requirements via importlib before shelling out to pip #25566

New Issue

GiteaMirror · 2026-04-20T06:00:06-05:00

GiteaMirror commented

2026-04-20 06:00:06 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20321
Author: @fractuscontext
Created: 1/2/2026
Status: ❌ Closed

Base: dev ← Head: fix-importlib

📝 Commits (9)

fe6783c Merge pull request #19030 from open-webui/dev
fc05e0a Merge pull request #19405 from open-webui/dev
e3faec6 Merge pull request #19416 from open-webui/dev
9899293 Merge pull request #19448 from open-webui/dev
140605e Merge pull request #19462 from open-webui/dev
6f1486f Merge pull request #19466 from open-webui/dev
d95f533 Merge pull request #19729 from open-webui/dev
a727153 0.6.43 (#20093)
f54bf11 fix: check requirements via importlib before shelling out to pip

📊 Changes

1 file changed (+45 additions, -12 deletions)

View changed files

📝 backend/open_webui/utils/plugin.py (+45 -12)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR modifies the install_frontmatter_requirements function to be smarter about dependency management.

Previously, the system would unconditionally run pip install via a subprocess for any requirement found in a tool's frontmatter. This caused immediate crashes in environments where direct pip usage is restricted or redundant (e.g., uv, poetry, NixOS), even if the packages were already installed.

This fix uses importlib.metadata to verify if requirements are already satisfied in the current environment before attempting any installation. If packages are missing and the automatic installer fails, it now raises a helpful exception to the UI rather than crashing the backend.

Added

Logic and deps to check importlib.metadata for existing packages before installation.
Less confusing error handling that suggests manual installation if the subprocess fails for uv users

Changed

Updated install_frontmatter_requirements to skip subprocess calls if requirements are met.

Deprecated

N/A

Removed

N/A

Fixed

Fixed backend crashes in uv/Nix environments when loading Tools with requirements frontmatter.
Prevented redundant pip install attempts for packages that are already present.

Security

N/A

Breaking Changes

No breaking changes

Additional Information

The issue was encountered using uv with Python 3.11.
Before: Loading a tool with requirements: httpx>=0.24.0 resulted in subprocess.CalledProcessError: exit status 1 because pip cannot run inside the locked environment.
After: The system detects httpx is already installed (via uv pip install open-webui) and skips the subprocess call, loading the tool successfully.
If a dependency is genuinely missing and pip fails (due to environment restrictions), the UI now displays: "WARNING: Failed to install dependencies via pip subprocess... please install these packages manually."
Closes [PR #413] [MERGED] dev (#20320)

Screenshots or Videos

N/A

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20321 **Author:** [@fractuscontext](https://github.com/fractuscontext) **Created:** 1/2/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-importlib` --- ### 📝 Commits (9) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`f54bf11`](https://github.com/open-webui/open-webui/commit/f54bf112c5447246d8cd65858ac410cddf458221) fix: check requirements via importlib before shelling out to pip ### 📊 Changes **1 file changed** (+45 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/plugin.py` (+45 -12) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR modifies the `install_frontmatter_requirements` function to be smarter about dependency management. Previously, the system would unconditionally run `pip install` via a subprocess for any requirement found in a tool's frontmatter. This caused immediate crashes in environments where direct `pip` usage is restricted or redundant (e.g., `uv`, `poetry`, `NixOS`), even if the packages were already installed. This fix uses `importlib.metadata` to verify if requirements are already satisfied in the current environment before attempting any installation. If packages are missing and the automatic installer fails, it now raises a helpful exception to the UI rather than crashing the backend. ### Added - Logic and deps to check `importlib.metadata` for existing packages before installation. - Less confusing error handling that suggests manual installation if the subprocess fails for `uv` users ### Changed - Updated `install_frontmatter_requirements` to skip `subprocess` calls if requirements are met. ### Deprecated - N/A ### Removed - N/A ### Fixed - Fixed backend crashes in `uv`/`Nix` environments when loading Tools with `requirements` frontmatter. - Prevented redundant `pip install` attempts for packages that are already present. ### Security - N/A ### Breaking Changes No breaking changes --- ### Additional Information - The issue was encountered using `uv` with Python 3.11. - **Before:** Loading a tool with `requirements: httpx>=0.24.0` resulted in `subprocess.CalledProcessError: exit status 1` because `pip` cannot run inside the locked environment. - **After:** The system detects `httpx` is already installed (via `uv pip install open-webui`) and skips the subprocess call, loading the tool successfully. - If a dependency is genuinely missing and `pip` fails (due to environment restrictions), the UI now displays: *"WARNING: Failed to install dependencies via pip subprocess... please install these packages manually."* - Closes #20320 ### Screenshots or Videos - N/A ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 06:00:06 -05:00

GiteaMirror closed this issue

2026-04-20 06:00:07 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#25566