[PR #20278] [MERGED] fix: prevent update_user_settings_by_id crash when user is None #25541

New Issue

GiteaMirror · 2026-04-20T05:59:07-05:00

GiteaMirror commented

2026-04-20 05:59:07 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20278
Author: @Classic298
Created: 12/30/2025
Status: ✅ Merged
Merged: 12/31/2025
Merged by: @tjbck

Base: dev ← Head: fix/issue-018-user-settings-null

📝 Commits (1)

a24a944 fix: prevent update_user_settings_by_id crash when user is None

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 backend/open_webui/models/users.py (+5 -1)

📄 Description

Get user first and check for None before accessing .settings attribute. Returns None gracefully instead of crashing with AttributeError.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20278 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 12/30/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/issue-018-user-settings-null` --- ### 📝 Commits (1) - [`a24a944`](https://github.com/open-webui/open-webui/commit/a24a9446e6f5e0998d537dc1deb866295cacce2a) fix: prevent update_user_settings_by_id crash when user is None ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/users.py` (+5 -1) </details> ### 📄 Description Get user first and check for None before accessing .settings attribute. Returns None gracefully instead of crashing with AttributeError. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 05:59:07 -05:00

GiteaMirror closed this issue

2026-04-20 05:59:08 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#25541