github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #20144] [CLOSED] fix: using AIOHTTP_CLIENT_SESSION_SSL env variable for some requests made to external tools (tika, ollama embeddings, external reranker api) #25481

New Issue
Closed
opened 2026-04-20 05:57:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 05:57:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20144
Author: @orKL3mlz
Created: 12/23/2025
Status: ❌ Closed

Base: dev ← Head: main

📝 Commits (9)

📊 Changes

3 files changed (+12 additions, -4 deletions)

View changed files

📝 backend/open_webui/retrieval/loaders/main.py (+5 -2)
📝 backend/open_webui/retrieval/models/external.py (+5 -1)
📝 backend/open_webui/retrieval/utils.py (+2 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • When setting AIOHTTP_CLIENT_SESSION_SSL to False some requests made to external APIs are still blocked because of the SSL certificate verification failing when it's self-signed, for example.
  • This PR make some fixes by using the AIOHTTP_CLIENT_SESSION_SSL environment variable to fix the behavior of some requests made to these external APIs.
  • Note: The changes that I've made here are only for the tools that I've used and that were not working, especially inside the Documents settings (Tika, Ollama Embeddings, External API Reranker), which means that there may be some other requests still failing despite these changes.

Fixed

  • Edited the class TikaLoader inside backend/open_webui/retrieval/loaders/main.py by adding verify=AIOHTTP_CLIENT_SESSION_SSL to request.put (line 117)
  • Edited the class ExternalReranker inside backend/open_webui/retrieval/models/external.py by adding verify=AIOHTTP_CLIENT_SESSION_SSL to requests.post (line 53)
  • Edited the function agenerate_ollama_batch_embeddings inside backend/open_webui/retrieval/utils.py by adding ssl=AIOHTTP_CLIENT_SESSION_SSL to session.post (line 765)

Security

  • Some of the requests will not fail anymore if the variable AIOHTTP_CLIENT_SESSION_SSL is set to False. So if this was an expected behavior, requests will go through instead of failing because the certificate is not checked anymore.

Additional Information

PYTHONHTTPSVERIFY = 0
ENABLE_WEB_LOADER_SSL_VERIFICATION = False
AIOHTTP_CLIENT_SESSION_SSL = False
AIOHTTP_CLIENT_SESSION_TOOL_SERVER_SSL = False

Screenshots or Videos

Without the code change, when importing a document

Tika SSL self-signed certificate error

image

If switching to a Tika HTTP endpoint instead of HTTPS, if a self-signed certificate is used to communicate with ollama embedding, it fails with this error in the backend

ERROR    | open_webui.retrieval.utils:agenerate_ollama_batch_embeddings:773 - Error generating ollama batch embeddings: Cannot connect to host <IP>:443 ssl:True [SSLCertVerificationError: (1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1016)')]

and in the frontend

image

With the code change, when importing a document

Everything goes smoothly and the document is processed correctly. (Can provide a screenshot if needed).

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20144 **Author:** [@orKL3mlz](https://github.com/orKL3mlz) **Created:** 12/23/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (9) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`1f1cde4`](https://github.com/open-webui/open-webui/commit/1f1cde4c9ecfdcfe21487e3a644cc10a92ab94a3) Use AIOHTTP_CLIENT_SESSION_SSL for connection to external tools ### 📊 Changes **3 files changed** (+12 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/loaders/main.py` (+5 -2) 📝 `backend/open_webui/retrieval/models/external.py` (+5 -1) 📝 `backend/open_webui/retrieval/utils.py` (+2 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - When setting `AIOHTTP_CLIENT_SESSION_SSL` to `False` some requests made to external APIs are still blocked because of the SSL certificate verification failing when it's self-signed, for example. - This PR make some fixes by using the `AIOHTTP_CLIENT_SESSION_SSL` environment variable to fix the behavior of some requests made to these external APIs. - **Note:** The changes that I've made here are only for the tools that I've used and that were not working, especially inside the Documents settings (Tika, Ollama Embeddings, External API Reranker), which means that there may be some other requests still failing despite these changes. ### Fixed - Edited the class `TikaLoader` inside `backend/open_webui/retrieval/loaders/main.py` by adding `verify=AIOHTTP_CLIENT_SESSION_SSL` to `request.put` (line 117) - Edited the class `ExternalReranker` inside `backend/open_webui/retrieval/models/external.py` by adding `verify=AIOHTTP_CLIENT_SESSION_SSL` to `requests.post` (line 53) - Edited the function `agenerate_ollama_batch_embeddings` inside `backend/open_webui/retrieval/utils.py` by adding `ssl=AIOHTTP_CLIENT_SESSION_SSL` to `session.post` (line 765) ### Security - Some of the requests will not fail anymore if the variable `AIOHTTP_CLIENT_SESSION_SSL` is set to `False`. So if this was an expected behavior, requests will go through instead of failing because the certificate is not checked anymore. --- ### Additional Information - Discussion made here before making this PR, and the fact that none of these environment variables had a positive impact on the requests. https://github.com/open-webui/open-webui/discussions/19968 ``` PYTHONHTTPSVERIFY = 0 ENABLE_WEB_LOADER_SSL_VERIFICATION = False AIOHTTP_CLIENT_SESSION_SSL = False AIOHTTP_CLIENT_SESSION_TOOL_SERVER_SSL = False ``` ### Screenshots or Videos #### Without the code change, when importing a document Tika SSL self-signed certificate error <img width="351" height="169" alt="image" src="https://github.com/user-attachments/assets/6b8fcf11-d9b8-42e5-93d4-66a4b85f7b77" /> If switching to a Tika HTTP endpoint instead of HTTPS, if a self-signed certificate is used to communicate with ollama embedding, it fails with this error in the backend ``` ERROR | open_webui.retrieval.utils:agenerate_ollama_batch_embeddings:773 - Error generating ollama batch embeddings: Cannot connect to host <IP>:443 ssl:True [SSLCertVerificationError: (1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1016)')] ``` and in the frontend <img width="206" height="50" alt="image" src="https://github.com/user-attachments/assets/eda149e9-a093-4e86-967d-545fc7c641e3" /> #### With the code change, when importing a document Everything goes smoothly and the document is processed correctly. (Can provide a screenshot if needed). ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 05:57:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#25481
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?