[PR #20010] [CLOSED] perf: optimize /api/models endpoint performance using batched loading #25427

New Issue

GiteaMirror · 2026-04-20T05:56:02-05:00

GiteaMirror commented

2026-04-20 05:56:02 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20010
Author: @Classic298
Created: 12/17/2025
Status: ❌ Closed

Base: dev ← Head: perf-models-api

📝 Commits (1)

11c7835 docs: Add comprehensive image storage analysis (#110)

📊 Changes

4 files changed (+52 additions, -3 deletions)

View changed files

📝 backend/open_webui/models/models.py (+32 -0)
📝 backend/open_webui/routers/ollama.py (+5 -1)
📝 backend/open_webui/routers/openai.py (+5 -1)
📝 backend/open_webui/utils/models.py (+10 -1)

📄 Description

Fixes: #20004, #18950

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- feat: Introduces a new feature or enhancement to the codebase

Changelog Entry

Description

Optimizes /api/models endpoint performance by replacing sequential database queries with batch loading. The get_filtered_models() functions were calling Models.get_model_by_id() in a loop for each model, creating N database queries and loading heavy meta fields containing base64 profile images. This change reduces database queries from N to 1 and excludes unnecessary image data from access control checks.

Changed

Added ModelAccessControl response model containing only id, user_id, and access_control fields
Added get_models_access_control_by_ids() batch loading method to ModelsTable class
Updated get_filtered_models() in backend/open_webui/utils/models.py to use batch loading
Updated get_filtered_models() in backend/open_webui/routers/openai.py to use batch loading
Updated get_filtered_models() in backend/open_webui/routers/ollama.py to use batch loading

Fixed

Performance degradation in /api/models endpoint with increasing number of models (#20004, #18950)
Sequential database queries loading base64 profile images during access control checks

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

Database queries reduced from N (number of models) to 1 batch query
Meta field with base64 images excluded from access control queries
Significantly faster response times for endpoints with many models

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20010 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 12/17/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `perf-models-api` --- ### 📝 Commits (1) - [`11c7835`](https://github.com/open-webui/open-webui/commit/11c78358e04ef064a6fc0c04f3dc78198fdc6857) docs: Add comprehensive image storage analysis (#110) ### 📊 Changes **4 files changed** (+52 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/models.py` (+32 -0) 📝 `backend/open_webui/routers/ollama.py` (+5 -1) 📝 `backend/open_webui/routers/openai.py` (+5 -1) 📝 `backend/open_webui/utils/models.py` (+10 -1) </details> ### 📄 Description Fixes: #20004, #18950 # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **feat**: Introduces a new feature or enhancement to the codebase # Changelog Entry ### Description Optimizes /api/models endpoint performance by replacing sequential database queries with batch loading. The get_filtered_models() functions were calling Models.get_model_by_id() in a loop for each model, creating N database queries and loading heavy meta fields containing base64 profile images. This change reduces database queries from N to 1 and excludes unnecessary image data from access control checks. ### Changed - Added ModelAccessControl response model containing only id, user_id, and access_control fields - Added get_models_access_control_by_ids() batch loading method to ModelsTable class - Updated get_filtered_models() in backend/open_webui/utils/models.py to use batch loading - Updated get_filtered_models() in backend/open_webui/routers/openai.py to use batch loading - Updated get_filtered_models() in backend/open_webui/routers/ollama.py to use batch loading ### Fixed - Performance degradation in /api/models endpoint with increasing number of models (#20004, #18950) - Sequential database queries loading base64 profile images during access control checks ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - Database queries reduced from N (number of models) to 1 batch query - Meta field with base64 images excluded from access control queries - Significantly faster response times for endpoints with many models ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 05:56:02 -05:00

GiteaMirror closed this issue

2026-04-20 05:56:03 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#25427