[PR #19960] [MERGED] fix: preserve access_control when cloning prompts #25413

New Issue

GiteaMirror · 2026-04-20T05:55:38-05:00

GiteaMirror commented

2026-04-20 05:55:38 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19960
Author: @silentoplayz
Created: 12/15/2025
Status: ✅ Merged
Merged: 12/16/2025
Merged by: @tjbck

Base: dev ← Head: fix/issue-19360-prompt-clone-access-control

📝 Commits (2)

0957abc fix: preserve access_control when cloning prompts
d6d9b04 fix: clone access control

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 src/routes/(app)/workspace/prompts/create/+page.svelte (+2 -2)
📝 src/routes/(app)/workspace/tools/create/+page.svelte (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR fixes issue #19360 where cloned prompts lose their access_control settings. When a prompt was cloned, the access_control property was explicitly set to null, causing the cloned prompt to default to public access instead of inheriting the original's access permissions.
Additionally, the tools create page had a prop name mismatch (access_control vs accessControl) that prevented access control from being passed to the editor at all.

Changed

Prompts:
Modified /workspace/prompts/create/+page.svelte (lines 52, 71) to preserve access_control using !== undefined check instead of hardcoding to null.

Tools:

Modified /workspace/tools/create/+page.svelte (line 90) to:

Preserve access_control using !== undefined check
Fixed prop name from access_control to accessControl to match ToolkitEditor's expected prop
Why !== undefined instead of ?? operator: The nullish coalescing operator (??) treats both null and undefined as falsy, which would incorrectly convert public items (null) to private ({}). By explicitly checking !== undefined, we preserve:
Public (null) → stays null ✅
Private ({}) → stays {} ✅
Custom permissions → stays preserved ✅
Undefined → defaults to {} (private) ✅

Fixed

Fixed cloned prompts losing their access control settings: Cloned prompts now inherit access_control from the original.
Fixed cloned tools losing their access control settings: Cloned tools now correctly inherit access_control from the original.
Fixed tools not receiving access control data at all due to prop name mismatch (access_control vs accessControl).
Fixed public items being incorrectly converted to private when cloned.

Security

Improved security by ensuring cloned private/restricted items remain private/restricted instead of accidentally becoming public, and vice versa.

Additional Information

Related Issue: [GH-ISSUE #21030] CI: Please run Playwright API tests for PR #21029 (fork) (#19360)
Models already handle access control preservation correctly via ModelEditor.svelte and do not need changes.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19960 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 12/15/2025 **Status:** ✅ Merged **Merged:** 12/16/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/issue-19360-prompt-clone-access-control` --- ### 📝 Commits (2) - [`0957abc`](https://github.com/open-webui/open-webui/commit/0957abc667791e50f33ef2212fa2261ab477bef2) fix: preserve access_control when cloning prompts - [`d6d9b04`](https://github.com/open-webui/open-webui/commit/d6d9b0456d710586e4106b9dcab02ec24e62b069) fix: clone access control ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/routes/(app)/workspace/prompts/create/+page.svelte` (+2 -2) 📝 `src/routes/(app)/workspace/tools/create/+page.svelte` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This PR fixes issue #19360 where cloned prompts lose their `access_control` settings. When a prompt was cloned, the `access_control` property was explicitly set to `null`, causing the cloned prompt to default to public access instead of inheriting the original's access permissions. - Additionally, the tools create page had a prop name mismatch (`access_control` vs `accessControl`) that prevented access control from being passed to the editor at all. ### Changed **Prompts:** Modified `/workspace/prompts/create/+page.svelte` (lines 52, 71) to preserve `access_control` using `!== undefined` check instead of hardcoding to `null`. **Tools:** - Modified `/workspace/tools/create/+page.svelte` (line 90) to: 1. Preserve `access_control` using `!== undefined` check 2. Fixed prop name from `access_control` to `accessControl` to match ToolkitEditor's expected prop Why `!== undefined` instead of `??` operator: The nullish coalescing operator (`??`) treats both `null` and `undefined` as falsy, which would incorrectly convert public items (`null`) to private (`{}`). By explicitly checking `!== undefined`, we preserve: Public (`null`) → stays `null` ✅ Private (`{}`) → stays `{}` ✅ Custom permissions → stays preserved ✅ Undefined → defaults to `{}` (private) ✅ ### Fixed - Fixed cloned prompts losing their access control settings: Cloned prompts now inherit `access_control` from the original. - Fixed cloned tools losing their access control settings: Cloned tools now correctly inherit `access_control` from the original. - Fixed tools not receiving access control data at all due to prop name mismatch (`access_control` vs `accessControl`). - Fixed public items being incorrectly converted to private when cloned. ### Security - Improved security by ensuring cloned private/restricted items remain private/restricted instead of accidentally becoming public, and vice versa. --- ### Additional Information - Related Issue: #19360 - Models already handle access control preservation correctly via `ModelEditor.svelte` and do not need changes. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 05:55:38 -05:00

GiteaMirror closed this issue

2026-04-20 05:55:38 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#25413