github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-07 11:28:35 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #19957] [MERGED] fix: enforce global ENABLE_CHANNELS check on all channel endpoints #25411

New Issue
Closed
opened 2026-04-20 05:55:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 05:55:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19957
Author: @silentoplayz
Created: 12/15/2025
Status: ✅ Merged
Merged: 12/20/2025
Merged by: @tjbck

Base: dev ← Head: fix/enable-channels-global-check

📝 Commits (3)

📊 Changes

1 file changed (+107 additions, -16 deletions)

View changed files

📝 backend/open_webui/routers/channels.py (+107 -16)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • When channels are disabled globally via Settings > General > Channels (Beta), users with channel permissions in USER_PERMISSIONS could still fetch channels via API endpoints. This fix adds a FastAPI dependency, get_enabled_channels that checks if ENABLE_CHANNELS is True before processing any channel API request. When channels are globally disabled, all channel endpoints now return 403 Forbidden with the message "Channels are not enabled".
  • Also fixes [GH-ISSUE #23188] feat: support additional Anthropic tool_result content types (#19914)

Added

  • New get_enabled_channels dependency function in backend/open_webui/routers/channels.py that validates channels are globally enabled.

Changed

  • All 22 channel endpoints now include the get_enabled_channels dependency to enforce the global enable check.

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • Users with channel permissions can no longer fetch channels when channels are disabled globally (#19914)

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

Affected Endpoints (22 total):

GET /api/v1/channels/
GET /api/v1/channels/list
GET /api/v1/channels/users/{user_id}
POST /api/v1/channels/create
GET /api/v1/channels/{id}
GET /api/v1/channels/{id}/members
POST /api/v1/channels/{id}/members/active
POST /api/v1/channels/{id}/update/members/add
POST /api/v1/channels/{id}/update/members/remove
POST /api/v1/channels/{id}/update
DELETE /api/v1/channels/{id}/delete
GET /api/v1/channels/{id}/messages
GET /api/v1/channels/{id}/messages/pinned
POST /api/v1/channels/{id}/messages/post
GET /api/v1/channels/{id}/messages/{message_id}
GET /api/v1/channels/{id}/messages/{message_id}/data
POST /api/v1/channels/{id}/messages/{message_id}/pin
GET /api/v1/channels/{id}/messages/{message_id}/thread
POST /api/v1/channels/{id}/messages/{message_id}/update
POST /api/v1/channels/{id}/messages/{message_id}/reactions/add
POST /api/v1/channels/{id}/messages/{message_id}/reactions/remove
DELETE /api/v1/channels/{id}/messages/{message_id}/delete

No new dependencies were added.

No documentation updates are required. This is a bug fix that enforces expected behavior as described in the issue.

Screenshots or Videos

Steps to reproduce and verify:

  1. Log in as admin
  2. Go to Settings > General > Channels (Beta) and enable channels
  3. Create a test public channel
  4. Enable Channels in Admin Panel > Settings > Default Permissions
  5. Create a test user with "user" role
  6. Log in as the test user
  7. Verify channels load successfully (HTTP 200 in DevTools)
  8. Log back in as admin, disable channels in Settings > General
  9. Log in as the test user
  10. Verify channel requests now return 403 Forbidden with channels now inaccessible

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19957 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 12/15/2025 **Status:** ✅ Merged **Merged:** 12/20/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/enable-channels-global-check` --- ### 📝 Commits (3) - [`441c483`](https://github.com/open-webui/open-webui/commit/441c483c211f1ca22a62e58600b2094dd6a276d7) fix: enforce global ENABLE_CHANNELS check on all channel endpoints - [`1579756`](https://github.com/open-webui/open-webui/commit/1579756c0cfa93d4f9401d52907384ab2586c1ff) refac - [`b549f61`](https://github.com/open-webui/open-webui/commit/b549f611b267e6c8ff3b385f967c50622699f81f) refac ### 📊 Changes **1 file changed** (+107 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/channels.py` (+107 -16) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - When channels are disabled globally via `Settings > General > Channels (Beta)`, users with channel permissions in `USER_PERMISSIONS` could still fetch channels via API endpoints. This fix adds a FastAPI dependency, `get_enabled_channels` that checks if `ENABLE_CHANNELS` is `True` before processing any channel API request. When channels are globally disabled, all channel endpoints now return **403 Forbidden** with the message "Channels are not enabled". - Also fixes #19914 ### Added - New `get_enabled_channels` dependency function in `backend/open_webui/routers/channels.py` that validates channels are globally enabled. ### Changed - All 22 channel endpoints now include the `get_enabled_channels` dependency to enforce the global enable check. ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - Users with channel permissions can no longer fetch channels when channels are disabled globally (#19914) ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information **Affected Endpoints (22 total):** ``` GET /api/v1/channels/ GET /api/v1/channels/list GET /api/v1/channels/users/{user_id} POST /api/v1/channels/create GET /api/v1/channels/{id} GET /api/v1/channels/{id}/members POST /api/v1/channels/{id}/members/active POST /api/v1/channels/{id}/update/members/add POST /api/v1/channels/{id}/update/members/remove POST /api/v1/channels/{id}/update DELETE /api/v1/channels/{id}/delete GET /api/v1/channels/{id}/messages GET /api/v1/channels/{id}/messages/pinned POST /api/v1/channels/{id}/messages/post GET /api/v1/channels/{id}/messages/{message_id} GET /api/v1/channels/{id}/messages/{message_id}/data POST /api/v1/channels/{id}/messages/{message_id}/pin GET /api/v1/channels/{id}/messages/{message_id}/thread POST /api/v1/channels/{id}/messages/{message_id}/update POST /api/v1/channels/{id}/messages/{message_id}/reactions/add POST /api/v1/channels/{id}/messages/{message_id}/reactions/remove DELETE /api/v1/channels/{id}/messages/{message_id}/delete ``` **No new dependencies were added.** **No documentation updates are required.** This is a bug fix that enforces expected behavior as described in the issue. ### Screenshots or Videos **Steps to reproduce and verify:** 1. Log in as admin 2. Go to Settings > General > Channels (Beta) and enable channels 3. Create a test public channel 4. Enable Channels in Admin Panel > Settings > Default Permissions 5. Create a test user with "user" role 6. Log in as the test user 7. Verify channels load successfully (HTTP 200 in DevTools) 8. Log back in as admin, disable channels in Settings > General 9. Log in as the test user 10. Verify channel requests now return 403 Forbidden with channels now inaccessible ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 05:55:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#25411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?