github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-05 18:38:17 -05:00
Code Issues 1.1k Packages Projects Releases 126 Wiki Activity

[PR #19686] [CLOSED] Fix embedding model update logic #25309

New Issue
Closed
opened 2026-04-20 05:52:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 05:52:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19686
Author: @rcivek
Created: 12/2/2025
Status: ❌ Closed

Base: main ← Head: fix-embedding-model-update

📝 Commits (10+)

📊 Changes

215 files changed (+6269 additions, -1520 deletions)

View changed files

📝 backend/open_webui/config.py (+26 -4)
📝 backend/open_webui/main.py (+12 -3)
➕ backend/open_webui/migrations/versions/2f1211949ecc_update_message_and_channel_member_table.py (+103 -0)
📝 backend/open_webui/migrations/versions/38d63c18f30f_add_oauth_session_table.py (+32 -4)
➕ backend/open_webui/migrations/versions/90ef40d4714e_update_channel_and_channel_members_table.py (+81 -0)
➕ backend/open_webui/migrations/versions/b10670c03dd5_update_user_table.py (+251 -0)
📝 backend/open_webui/models/auths.py (+4 -12)
📝 backend/open_webui/models/channels.py (+550 -18)
📝 backend/open_webui/models/groups.py (+98 -16)
📝 backend/open_webui/models/messages.py (+103 -11)
📝 backend/open_webui/models/models.py (+53 -5)
📝 backend/open_webui/models/notes.py (+1 -1)
📝 backend/open_webui/models/oauth_sessions.py (+1 -1)
📝 backend/open_webui/models/tools.py (+1 -1)
📝 backend/open_webui/models/users.py (+222 -50)
📝 backend/open_webui/retrieval/vector/dbs/milvus_multitenancy.py (+0 -1)
📝 backend/open_webui/retrieval/web/main.py (+1 -1)
📝 backend/open_webui/routers/auths.py (+32 -7)
📝 backend/open_webui/routers/channels.py (+722 -109)
📝 backend/open_webui/routers/folders.py (+17 -1)

...and 80 more files

📄 Description

Summary

Fixes the embedding model update logic by correctly passing the auto_update flag to get_model_path.

Changes

  • Forward RAG_EMBEDDING_MODEL_AUTO_UPDATE to get_ef and get_model_path.
  • Ensure embedding models can update when auto-update is enabled.

Testing

Verified that models update correctly when auto-update is enabled and still work normally in offline mode.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19686 **Author:** [@rcivek](https://github.com/rcivek) **Created:** 12/2/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-embedding-model-update` --- ### 📝 Commits (10+) - [`69722ba`](https://github.com/open-webui/open-webui/commit/69722ba973768a5f689f2e2351bf583a8db9bba8) fix/refac: workspace shared model list - [`1bfe2c9`](https://github.com/open-webui/open-webui/commit/1bfe2c92ba27c67b17f1141aeded15e6ec99d150) Merge pull request #19464 from aleixdorca/dev - [`c7eb713`](https://github.com/open-webui/open-webui/commit/c7eb7136893b0ddfdc5d55ffc7a05bd84a00f5d6) fix: user preview profile image - [`c5b73d7`](https://github.com/open-webui/open-webui/commit/c5b73d71843edc024325d4a6e625ec939a747279) refac/fix: function name filter type - [`477097c`](https://github.com/open-webui/open-webui/commit/477097c2e42985c14892301d0127314629d07df1) refac - [`8b2015a`](https://github.com/open-webui/open-webui/commit/8b2015a97b88b05bde0f4631ba67b1108de25bcb) refac - [`4df5b7e`](https://github.com/open-webui/open-webui/commit/4df5b7eb2e4b39eb01d488de4c95444ce6dea88c) fix: update dependency to prevent rediss:// failure (#19488) - [`c631659`](https://github.com/open-webui/open-webui/commit/c6316593270cc5770bf4a2da463f6715e39042bc) i18n: de-de (#19471) - [`4370dee`](https://github.com/open-webui/open-webui/commit/4370dee79e19d77062c03fba81780cb3b779fca3) fix: async save docs to vector db - [`9fca496`](https://github.com/open-webui/open-webui/commit/9fca4969dbc23102280e7e56dcf24bd52e71ca87) chore: dep bump pypdf to ver 6.4.0 (#19508) ### 📊 Changes **215 files changed** (+6269 additions, -1520 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+26 -4) 📝 `backend/open_webui/main.py` (+12 -3) ➕ `backend/open_webui/migrations/versions/2f1211949ecc_update_message_and_channel_member_table.py` (+103 -0) 📝 `backend/open_webui/migrations/versions/38d63c18f30f_add_oauth_session_table.py` (+32 -4) ➕ `backend/open_webui/migrations/versions/90ef40d4714e_update_channel_and_channel_members_table.py` (+81 -0) ➕ `backend/open_webui/migrations/versions/b10670c03dd5_update_user_table.py` (+251 -0) 📝 `backend/open_webui/models/auths.py` (+4 -12) 📝 `backend/open_webui/models/channels.py` (+550 -18) 📝 `backend/open_webui/models/groups.py` (+98 -16) 📝 `backend/open_webui/models/messages.py` (+103 -11) 📝 `backend/open_webui/models/models.py` (+53 -5) 📝 `backend/open_webui/models/notes.py` (+1 -1) 📝 `backend/open_webui/models/oauth_sessions.py` (+1 -1) 📝 `backend/open_webui/models/tools.py` (+1 -1) 📝 `backend/open_webui/models/users.py` (+222 -50) 📝 `backend/open_webui/retrieval/vector/dbs/milvus_multitenancy.py` (+0 -1) 📝 `backend/open_webui/retrieval/web/main.py` (+1 -1) 📝 `backend/open_webui/routers/auths.py` (+32 -7) 📝 `backend/open_webui/routers/channels.py` (+722 -109) 📝 `backend/open_webui/routers/folders.py` (+17 -1) _...and 80 more files_ </details> ### 📄 Description ### Summary Fixes the embedding model update logic by correctly passing the `auto_update` flag to `get_model_path`. ### Changes - Forward `RAG_EMBEDDING_MODEL_AUTO_UPDATE` to `get_ef` and `get_model_path`. - Ensure embedding models can update when auto-update is enabled. ### Testing Verified that models update correctly when auto-update is enabled and still work normally in offline mode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 05:52:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#25309
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?