github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #19545] [CLOSED] Fix/pdf export mermaid rendering #25245

New Issue
Closed
opened 2026-04-20 05:50:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 05:50:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19545
Author: @chaitu426
Created: 11/27/2025
Status: ❌ Closed

Base: dev ← Head: fix/pdf_export_mermaid_rendering

📝 Commits (6)

📊 Changes

1 file changed (+26 additions, -0 deletions)

View changed files

📝 src/lib/components/layout/Sidebar/ChatMenu.svelte (+26 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request.

Before submitting, ensure the following:

  • Target branch: dev
  • Description: Provided below
  • Changelog: Added at the bottom
  • Documentation: N/A for this fix
  • Dependencies: None
  • Testing: Not yet tested — needs manual verification
  • Agentic AI Code: Not used
  • Code review: Self-reviewed
  • Title Prefix: fix:

Fix: Mermaid diagrams not rendering in exported PDF

Fixes #19227

This PR ensures that Mermaid diagrams are fully rendered before html2canvas takes a snapshot for stylized PDF export.

Why this is needed

Currently, Mermaid diagrams are rendered after the DOM is cloned for PDF generation. This causes empty or broken diagrams in the exported PDF. Triggering Mermaid rendering before cloning ensures that all diagrams appear correctly.

What this PR changes

  • Adds a MERMAID_RENDER() step before cloning the chat DOM.
  • Hides chat action buttons during PDF export to prevent extra elements in the snapshot.
  • No UI, style, or layout changes — the fix is isolated to PDF export.

Testing notes

  • Existing chat functionality remains unaffected.
  • Exported PDFs now consistently include Mermaid diagrams as intended.
  • Safe, isolated fix with no side effects.

Changelog Entry

Fixed: Mermaid diagrams are intended to render correctly in exported PDFs, and chat action buttons are hidden during export.
Breaking Changes: None

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Acknowledgment

Thanks to @ShirasawaSama for reporting this issue in #19227.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19545 **Author:** [@chaitu426](https://github.com/chaitu426) **Created:** 11/27/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/pdf_export_mermaid_rendering` --- ### 📝 Commits (6) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`2189dd5`](https://github.com/open-webui/open-webui/commit/2189dd5c182f365db0354560e471bd8a670b211c) fix(pdf-export): prerender Mermaid before html2canvas snapshot ### 📊 Changes **1 file changed** (+26 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/layout/Sidebar/ChatMenu.svelte` (+26 -0) </details> ### 📄 Description ### Pull Request Checklist **Note to first-time contributors:** Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request. Before submitting, ensure the following: - Target branch: `dev` - Description: Provided below - Changelog: Added at the bottom - Documentation: N/A for this fix - Dependencies: None - Testing: **Not yet tested — needs manual verification** - Agentic AI Code: Not used - Code review: Self-reviewed - Title Prefix: `fix:` --- ### Fix: Mermaid diagrams not rendering in exported PDF Fixes #19227 This PR ensures that Mermaid diagrams are fully rendered **before** `html2canvas` takes a snapshot for stylized PDF export. --- ### Why this is needed Currently, Mermaid diagrams are rendered **after** the DOM is cloned for PDF generation. This causes empty or broken diagrams in the exported PDF. Triggering Mermaid rendering **before cloning** ensures that all diagrams appear correctly. --- ### What this PR changes - Adds a `MERMAID_RENDER()` step **before cloning** the chat DOM. - Hides chat action buttons during PDF export to prevent extra elements in the snapshot. - No UI, style, or layout changes — the fix is isolated to PDF export. --- ### Testing notes - Existing chat functionality remains unaffected. - Exported PDFs now consistently include Mermaid diagrams as intended. - Safe, isolated fix with no side effects. --- ### Changelog Entry **Fixed:** Mermaid diagrams are intended to render correctly in exported PDFs, and chat action buttons are hidden during export. **Breaking Changes:** None --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. ### Acknowledgment Thanks to @ShirasawaSama for reporting this issue in #19227. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 05:50:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#25245
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?