[PR #19499] [CLOSED] fix: sending json-like value in docling params throwing error #25232

New Issue

GiteaMirror · 2026-04-20T05:50:00-05:00

GiteaMirror commented

2026-04-20 05:50:00 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19499
Author: @Hsienz
Created: 11/26/2025
Status: ❌ Closed

Base: dev ← Head: fix-sending-json-like-value-in-docling-params-throw-error

📝 Commits (8)

fe6783c Merge pull request #19030 from open-webui/dev
fc05e0a Merge pull request #19405 from open-webui/dev
e3faec6 Merge pull request #19416 from open-webui/dev
9899293 Merge pull request #19448 from open-webui/dev
140605e Merge pull request #19462 from open-webui/dev
cd7b955 fix(docling): fix sending json-like value cause error
964e350 chore: remove comment
d45de37 fix(docling): fix after file uploaded, json-like value in docling params

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 backend/open_webui/retrieval/loaders/main.py (+8 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

According to docs form docling-serve, there are only parameters accept json string.
So when params is set to the following in admin panel.
{
...
"picture_description_api": { "url": "http://example.com" }
...
}

picture_description_api would send as dict and cause error.
Because there is no parameter accept dict, so I dumped all dict value back to str.

Fixed

Fix sending json-like value in docling params throwing error.

Additional Information

openvino 0.6.40
docling-serve 1.8.0
docling 2.61.1

Screenshots or Videos

Docling params:

Before:

Error notification:

Empty file content:

Docling-serve container error log:

After:

File content:

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19499 **Author:** [@Hsienz](https://github.com/Hsienz) **Created:** 11/26/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-sending-json-like-value-in-docling-params-throw-error` --- ### 📝 Commits (8) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`cd7b955`](https://github.com/open-webui/open-webui/commit/cd7b955e33818afa526190ffcf7cc7fc90ce0f9f) fix(docling): fix sending json-like value cause error - [`964e350`](https://github.com/open-webui/open-webui/commit/964e3504fccae491f0b4a6e018e955e46bd7c23d) chore: remove comment - [`d45de37`](https://github.com/open-webui/open-webui/commit/d45de3786608139a678720c0f75ee23a545317b3) fix(docling): fix after file uploaded, json-like value in docling params ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/loaders/main.py` (+8 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description According to docs form docling-serve, there are only parameters accept json string. So when params is set to the following in admin panel. { ... "picture_description_api": { "url": "http://example.com" } ... } picture_description_api would send as dict and cause error. Because there is no parameter accept dict, so I dumped all dict value back to str. ### Fixed - Fix sending json-like value in docling params throwing error. --- ### Additional Information openvino 0.6.40 docling-serve 1.8.0 docling 2.61.1 ### Screenshots or Videos Docling params: <img width="1577" height="880" alt="image" src="https://github.com/user-attachments/assets/8f9b5699-5076-4e0e-b331-f9a05a2c3eba" /> ## Before: Error notification: <img width="1284" height="566" alt="image" src="https://github.com/user-attachments/assets/6d47100a-ed0b-44ef-9f79-cd415f9c071b" /> Empty file content: <img width="1308" height="406" alt="image" src="https://github.com/user-attachments/assets/7cda8485-62e6-4306-97fe-8b55df775a2b" /> Docling-serve container error log: <img width="1192" height="162" alt="image" src="https://github.com/user-attachments/assets/9239fd8c-9e5c-4b76-8317-74e610346ff0" /> ## After: File content: <img width="1195" height="681" alt="image" src="https://github.com/user-attachments/assets/faf7aab4-e41e-471b-a25e-2d86c37d9edb" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 05:50:00 -05:00

GiteaMirror closed this issue

2026-04-20 05:50:01 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#25232