github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-08-30 17:25:30 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

Memory creation fails when using Milvus Vector DB #2508

New Issue
Closed
opened 2025-11-11 15:08:49 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-11 15:08:49 -06:00
Owner
Copy Link
Copy Source

Originally created by @jasonpnnl on GitHub (Oct 29, 2024).

Installation Method

git clone

Environment

  • Open WebUI Version: v0.3.35

  • Operating System: Windows 10, Debian Bookworm

Confirmation:

  • I have read and followed all the instructions provided in the README.md.
  • I am on the latest version of both Open WebUI and Ollama.
  • I have included the browser console logs.
  • I have included the Docker container logs.
  • I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:

Memory is created by creating a collection when using both Chroma and Milvus

Actual Behavior:

Memory is not added. Silently fails.
Receive error from backend:
pymilvus.exceptions.MilvusException: <MilvusException: (code=1100, message=Invalid collection open_webui_user-memory-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. , collection name can only contain numbers, letters and underscores: invalid parameter)>

Description

Bug Summary:
Memories.py creates collections using names that contain dashes. Milvus does not allow dashes so this fails.

Reproduction Details

Steps to Reproduce:

  1. Configure OpenWebUI to use Milvus instead of Chroma for vector db
  2. Add a Memory

Logs and Screenshots

pymilvus.exceptions.MilvusException: <MilvusException: (code=1100, message=Invalid collection open_webui_user-memory-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. , collection name can only contain numbers, letters and underscores: invalid parameter)>
image

Additional Information

I have a proposal for how to fix this and can submit a PR. Instead of setting the collection name with dashes in it multiple times in memories.py, create a function, get_collection_name that returns collection_name but with dashes replaced with underscores if the VECTOR_DB_CLIENT is MilvusClient, otherwise return collection_name as currently implemented to keep backward compatibility.

Originally created by @jasonpnnl on GitHub (Oct 29, 2024). --- ## Installation Method git clone ## Environment - **Open WebUI Version:** v0.3.35 - **Operating System:** Windows 10, Debian Bookworm **Confirmation:** - [X] I have read and followed all the instructions provided in the README.md. - [X] I am on the latest version of both Open WebUI and Ollama. - [ ] I have included the browser console logs. - [ ] I have included the Docker container logs. - [X] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below. ## Expected Behavior: Memory is created by creating a collection when using both Chroma and Milvus ## Actual Behavior: Memory is not added. Silently fails. Receive error from backend: pymilvus.exceptions.MilvusException: <MilvusException: (code=1100, message=Invalid collection open_webui_user-memory-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. , collection name can only contain numbers, letters and underscores: invalid parameter)> ## Description **Bug Summary:** Memories.py creates collections using names that contain dashes. Milvus does not allow dashes so this fails. ## Reproduction Details **Steps to Reproduce:** 1. Configure OpenWebUI to use Milvus instead of Chroma for vector db 2. Add a Memory ## Logs and Screenshots pymilvus.exceptions.MilvusException: <MilvusException: (code=1100, message=Invalid collection open_webui_user-memory-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. , collection name can only contain numbers, letters and underscores: invalid parameter)> ![image](https://github.com/user-attachments/assets/5d59e5dd-ba3c-4aa4-8a97-24766f94a1e3) ## Additional Information I have a proposal for how to fix this and can submit a PR. Instead of setting the collection name with dashes in it multiple times in memories.py, create a function, get_collection_name that returns collection_name but with dashes replaced with underscores if the VECTOR_DB_CLIENT is MilvusClient, otherwise return collection_name as currently implemented to keep backward compatibility.
GiteaMirror commented 2025-11-11 15:08:50 -06:00
Author
Owner
Copy Link
Copy Source

@jasonpnnl commented on GitHub (Oct 29, 2024):

I had tested this on a previous version and then saw it was still present in the latest version in memories.py. However, upon further review I can see that there was code added to apps/retrieval/vector/dbs/milvus.py to perform the replacements at that level. Sorry about the false report. I will be more careful checking in the future. This can be closed as it's actually fixed in the latest version.

@jasonpnnl commented on GitHub (Oct 29, 2024): I had tested this on a previous version and then saw it was still present in the latest version in memories.py. However, upon further review I can see that there was code added to apps/retrieval/vector/dbs/milvus.py to perform the replacements at that level. Sorry about the false report. I will be more careful checking in the future. This can be closed as it's actually fixed in the latest version.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#2508