[PR #18762] [CLOSED] fix: audio deletes existing text/prompt #24909

Closed
opened 2026-04-20 05:38:59 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18762
Author: @acomarcho
Created: 10/31/2025
Status: Closed

Base: devHead: fix/audio-replaces-prompt


📝 Commits (1)

  • ad8c905 fix: audio deletes existing text/prompt

📊 Changes

1 file changed (+32 additions, -30 deletions)

View changed files

📝 src/lib/components/chat/MessageInput.svelte (+32 -30)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR fixes this issue: https://github.com/open-webui/open-webui/issues/18540 .

For the technical details, see the "additional information" part.

I made sure that the autocompletion for commands still work (for /, @, or #), as it has a little logic change at insertTextAtCursor which is used by it too.

Added

None

Changed

None

Deprecated

None

Removed

None

Fixed

Fixes an issue where using STT replaces existing text/prompt.

Security

None

Breaking Changes

None


Additional Information

Technical details:

  • Using conditional rendering resets the state. The rich text editor will begin with a blank state every time the voice recording ends, hence resetting the prompts.
  • Using CSS to hide it, meanwhile, preserves the state.
  • The #key at the voice component is used to reset the state of the voice recording component. If we don't have this, once you click record again, you will still see the previous waveform.
  • Added && showCommands to fix an issue where if you are dictating when your cursor is at the end of a word, it will replace that word (because it's considered a part of a command). This ensures that it will only replace if it's a running command (i.e. starting with '@', '/', or '#')

Issue: https://github.com/open-webui/open-webui/issues/18540

Screenshots or Videos

https://github.com/user-attachments/assets/e84f1b4d-5bb4-4f34-9278-e98b65b3694a

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18762 **Author:** [@acomarcho](https://github.com/acomarcho) **Created:** 10/31/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/audio-replaces-prompt` --- ### 📝 Commits (1) - [`ad8c905`](https://github.com/open-webui/open-webui/commit/ad8c905a84ce3a8a3fadff4a081aa012ec071ace) fix: audio deletes existing text/prompt ### 📊 Changes **1 file changed** (+32 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/MessageInput.svelte` (+32 -30) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [x] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR fixes this issue: https://github.com/open-webui/open-webui/issues/18540 . For the technical details, see the "additional information" part. I made sure that the autocompletion for commands still work (for `/`, `@`, or `#`), as it has a little logic change at `insertTextAtCursor` which is used by it too. ### Added None ### Changed None ### Deprecated None ### Removed None ### Fixed Fixes an issue where using STT replaces existing text/prompt. ### Security None ### Breaking Changes None --- ### Additional Information Technical details: - Using conditional rendering **resets the state**. The rich text editor will begin with a blank state every time the voice recording ends, hence resetting the prompts. - Using CSS to hide it, meanwhile, preserves the state. - The `#key` at the voice component is used to reset the state of the voice recording component. If we don't have this, once you click record again, you will still see the previous waveform. - Added `&& showCommands` to fix an issue where if you are dictating when your cursor is at the end of a word, it will replace that word (because it's considered a part of a command). This ensures that it will only replace if it's a running command (i.e. starting with '@', '/', or '#') Issue: https://github.com/open-webui/open-webui/issues/18540 ### Screenshots or Videos https://github.com/user-attachments/assets/e84f1b4d-5bb4-4f34-9278-e98b65b3694a ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 05:38:59 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#24909