[PR #18761] [MERGED] fix: chat title not generated if title auto generation is off in interface settings #24908

New Issue

GiteaMirror · 2026-04-20T05:38:57-05:00

GiteaMirror commented

2026-04-20 05:38:57 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18761
Author: @acomarcho
Created: 10/31/2025
Status: ✅ Merged
Merged: 11/1/2025
Merged by: @tjbck

Base: dev ← Head: fix/chat-title-not-generated-if-title-auto-generation-is-off

📝 Commits (1)

15cc9b6 fix: titles are not generated if title auto-generation is set to false in interface settings

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+0 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixes a bug reported by @silentoplayz as per this comment: https://github.com/open-webui/open-webui/issues/18717#issuecomment-3462607835

It seems like chat titles are not generated if the title auto generation is set off in interface settings.

A short investigation showed there are some problems introduced by this commit: 3a601e0fc3 (diff-73e28dd627aa137e2c628a274c7493f8d758cc857d7a7e8887652442b733aa88)

As you can see, it adds in an extra check for if tasks[TASKS.TITLE_GENERATION] in the outer block when it's supposed to be put in the inner block. It makes the branch unreachable, thus the title of the chat is not generated.

Added

None

Changed

None

Deprecated

None

Removed

None

Fixed

Chat titles are now set properly if the title auto generation is set off in interface settings.

Security

None

Breaking Changes

None

Additional Information

None

Screenshots or Videos

Before fix:

https://github.com/user-attachments/assets/e1f00b26-99ea-4f82-9b2a-250d79e56155

After fix:

https://github.com/user-attachments/assets/4b358c82-d323-4ac6-a762-255650f02783

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18761 **Author:** [@acomarcho](https://github.com/acomarcho) **Created:** 10/31/2025 **Status:** ✅ Merged **Merged:** 11/1/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/chat-title-not-generated-if-title-auto-generation-is-off` --- ### 📝 Commits (1) - [`15cc9b6`](https://github.com/open-webui/open-webui/commit/15cc9b6cee9e5273a8c39e832e9df9d563bd9b13) fix: titles are not generated if title auto-generation is set to false in interface settings ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+0 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [x] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Fixes a bug reported by @silentoplayz as per this comment: https://github.com/open-webui/open-webui/issues/18717#issuecomment-3462607835 It seems like chat titles are not generated if the title auto generation is set off in interface settings. A short investigation showed there are some problems introduced by this commit: https://github.com/open-webui/open-webui/commit/3a601e0fc39aef341e4051ce6ae1da83361cd050#diff-73e28dd627aa137e2c628a274c7493f8d758cc857d7a7e8887652442b733aa88 <img width="736" height="669" alt="image" src="https://github.com/user-attachments/assets/1c5bb434-14e9-4ae7-91e0-ba6eb4d368d4" /> As you can see, it adds in an extra check for ` if tasks[TASKS.TITLE_GENERATION]` in the outer block when it's supposed to be put in the inner block. It makes the branch unreachable, thus the title of the chat is not generated. <img width="656" height="685" alt="image" src="https://github.com/user-attachments/assets/7b3de028-d90b-478e-9aff-ca7ba96d71d9" /> ### Added None ### Changed None ### Deprecated None ### Removed None ### Fixed - Chat titles are now set properly if the title auto generation is set off in interface settings. ### Security None ### Breaking Changes None --- ### Additional Information None ### Screenshots or Videos Before fix: https://github.com/user-attachments/assets/e1f00b26-99ea-4f82-9b2a-250d79e56155 After fix: https://github.com/user-attachments/assets/4b358c82-d323-4ac6-a762-255650f02783 ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 05:38:57 -05:00

GiteaMirror closed this issue

2026-04-20 05:38:58 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#24908