[PR #18065] [CLOSED] fix(oauth): correctly access server_metadata_url #24659

New Issue

GiteaMirror · 2026-04-20T05:31:35-05:00

GiteaMirror commented

2026-04-20 05:31:35 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18065
Author: @ndrsfel
Created: 10/5/2025
Status: ❌ Closed

Base: dev ← Head: fix/server_metadata_url

📝 Commits (1)

9bbc696 fix(oauth): correctly access server_metadata_url

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 backend/open_webui/utils/oauth.py (+4 -4)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

OAuthManager and OAuthClientManager expose the server_metadata_url by accessing the private attribute client._server_metadata_url instead of client.server_metadata_url. This PR allows for proper access to this attribute in get_server_metadata_url(). Fixes automatic token refresh (server_metadata_url has been None before) and logout using microsoft OAuth provider without setting OPENID_PROVIDER_URL

Fixed

get_server_metadata_url() of OAuthManager and OAuthClientManager

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18065 **Author:** [@ndrsfel](https://github.com/ndrsfel) **Created:** 10/5/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/server_metadata_url` --- ### 📝 Commits (1) - [`9bbc696`](https://github.com/open-webui/open-webui/commit/9bbc6960670c980086c6de079fb8ea48976c98e4) fix(oauth): correctly access server_metadata_url ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/oauth.py` (+4 -4) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - `OAuthManager` and `OAuthClientManager` expose the `server_metadata_url` by accessing the private attribute `client._server_metadata_url` instead of `client.server_metadata_url`. This PR allows for proper access to this attribute in `get_server_metadata_url()`. Fixes automatic token refresh (server_metadata_url has been None before) and logout using `microsoft` OAuth provider without setting `OPENID_PROVIDER_URL` ### Fixed - `get_server_metadata_url()` of `OAuthManager` and `OAuthClientManager` --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 05:31:35 -05:00

GiteaMirror closed this issue

2026-04-20 05:31:36 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#24659