github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-08-30 17:25:30 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

issue: OIDC login fails - Boolean variables are not accessed correctly #2449

New Issue
Closed
opened 2025-11-11 15:07:31 -06:00 by GiteaMirror · 9 comments
GiteaMirror commented 2025-11-11 15:07:31 -06:00
Owner
Copy Link
Copy Source

Originally created by @nodomain on GitHub (Oct 24, 2024).

Bug Report

Installation Method

Docker (AWS ECS)

Environment

  • Open WebUI Version: v0.3.33

Confirmation:

  • I have read and followed all the instructions provided in the README.md.
  • I am on the latest version of both Open WebUI and Ollama.
  • I have included the browser console logs.
  • I have included the Docker container logs.
  • I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:

Login via OIDC EntraID works

Actual Behavior:

Internal Server Error happens.

Description

Bug Summary:
Boolean variables are not accessed correctly

Reproduction Details

Steps to Reproduce:
Set the needed OIDC variables in the ECS Task Definition e.g.

    { name = "ENABLE_OAUTH_SIGNUP", value = "true" },           # Boolean value as string
    { name = "OAUTH_MERGE_ACCOUNTS_BY_EMAIL", value = "true" }, # Boolean value as string

Logs and Screenshots

...
 File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 278, in app
    raw_response = await run_endpoint_function(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 191, in run_endpoint_function
    return await dependant.call(**values)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/backend/open_webui/main.py", line 2372, in oauth_callback
    return await oauth_manager.handle_callback(provider, request, response)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/backend/open_webui/utils/oauth.py", line 165, in handle_callback
    if auth_manager_config.OAUTH_MERGE_ACCOUNTS_BY_EMAIL.value:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...

Additional Information

The boolean values seem to be accessible without ".value" and hence the call fails.

Note

If the bug report is incomplete or does not follow the provided instructions, it may not be addressed. Please ensure that you have followed the steps outlined in the README.md and troubleshooting.md documents, and provide all necessary information for us to reproduce and address the issue. Thank you!

Originally created by @nodomain on GitHub (Oct 24, 2024). # Bug Report ## Installation Method Docker (AWS ECS) ## Environment - **Open WebUI Version:** v0.3.33 **Confirmation:** - [x] I have read and followed all the instructions provided in the README.md. - [x] I am on the latest version of both Open WebUI and Ollama. - [x] I have included the browser console logs. - [x] I have included the Docker container logs. - [x] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below. ## Expected Behavior: Login via OIDC EntraID works ## Actual Behavior: Internal Server Error happens. ## Description **Bug Summary:** Boolean variables are not accessed correctly ## Reproduction Details **Steps to Reproduce:** Set the needed OIDC variables in the ECS Task Definition e.g. ```json { name = "ENABLE_OAUTH_SIGNUP", value = "true" }, # Boolean value as string { name = "OAUTH_MERGE_ACCOUNTS_BY_EMAIL", value = "true" }, # Boolean value as string ``` ## Logs and Screenshots ```text ... File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 278, in app raw_response = await run_endpoint_function( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 191, in run_endpoint_function return await dependant.call(**values) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/app/backend/open_webui/main.py", line 2372, in oauth_callback return await oauth_manager.handle_callback(provider, request, response) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/app/backend/open_webui/utils/oauth.py", line 165, in handle_callback if auth_manager_config.OAUTH_MERGE_ACCOUNTS_BY_EMAIL.value: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... ``` ## Additional Information The boolean values seem to be accessible without ".value" and hence the call fails. ## Note If the bug report is incomplete or does not follow the provided instructions, it may not be addressed. Please ensure that you have followed the steps outlined in the README.md and troubleshooting.md documents, and provide all necessary information for us to reproduce and address the issue. Thank you!
GiteaMirror commented 2025-11-11 15:07:31 -06:00
Author
Owner
Copy Link
Copy Source

@nodomain commented on GitHub (Oct 24, 2024):

Console logs:

   GET https://xxx/oauth/microsoft/callback?code=0xxxxtvLFSTk&session_state=bff35b30-41f6-4247-a598-b456dcfd4120 500 (Internal Server Error)
@nodomain commented on GitHub (Oct 24, 2024): Console logs: GET https://xxx/oauth/microsoft/callback?code=0xxxxtvLFSTk&session_state=bff35b30-41f6-4247-a598-b456dcfd4120 500 (Internal Server Error)
GiteaMirror commented 2025-11-11 15:07:31 -06:00
Author
Owner
Copy Link
Copy Source

@tjbck commented on GitHub (Oct 24, 2024):

@Cyb4Black

@tjbck commented on GitHub (Oct 24, 2024): @Cyb4Black
GiteaMirror commented 2025-11-11 15:07:31 -06:00
Author
Owner
Copy Link
Copy Source

@nitinkr0411 commented on GitHub (Oct 25, 2024):

same issue

@nitinkr0411 commented on GitHub (Oct 25, 2024): same issue
GiteaMirror commented 2025-11-11 15:07:32 -06:00
Author
Owner
Copy Link
Copy Source

@tjbck commented on GitHub (Oct 25, 2024):

PR Welcome!

@tjbck commented on GitHub (Oct 25, 2024): PR Welcome!
GiteaMirror commented 2025-11-11 15:07:32 -06:00
Author
Owner
Copy Link
Copy Source

@nodomain commented on GitHub (Oct 25, 2024):

Already getting familiar with it ;)

@nodomain commented on GitHub (Oct 25, 2024): Already getting familiar with it ;)
GiteaMirror commented 2025-11-11 15:07:32 -06:00
Author
Owner
Copy Link
Copy Source

@brantje commented on GitHub (Oct 25, 2024):

If i remember correctly, on dev branch before the release, oauth login was broken, even with the booleans set.
Once a PR is ready i'll gladly test it. Since it seems @nodomain is already working on it :).

@brantje commented on GitHub (Oct 25, 2024): If i remember correctly, on dev branch before the release, oauth login was broken, even with the booleans set. Once a PR is ready i'll gladly test it. Since it seems @nodomain is already working on it :).
GiteaMirror commented 2025-11-11 15:07:32 -06:00
Author
Owner
Copy Link
Copy Source

@nodomain commented on GitHub (Oct 25, 2024):

I think i fixed it, at least works for me...
Since I am totally new to the codebase, I appreciate feedback...

@nodomain commented on GitHub (Oct 25, 2024): I think i fixed it, at least works for me... Since I am totally new to the codebase, I appreciate feedback...
GiteaMirror commented 2025-11-11 15:07:32 -06:00
Author
Owner
Copy Link
Copy Source

@Cyb4Black commented on GitHub (Oct 25, 2024):

Yes, the .value calls both need to be removed. They were actually already present before my larger OAuth changes. I'm pretty sure I removed them while coding, but it seems that some copy-pasting from the old function into my rework brought them back 😅.

So, #6392 is correctly fixing this.

Edit:
Just checked, Had them removed in the past, as I'm currently running an image from an intermediate commit in our productive cluster and it works just fine.

@Cyb4Black commented on GitHub (Oct 25, 2024): Yes, the .value calls both need to be removed. They were actually already present before my larger OAuth changes. I'm pretty sure I removed them while coding, but it seems that some copy-pasting from the old function into my rework brought them back 😅. So, #6392 is correctly fixing this. Edit: Just checked, Had them removed in the past, as I'm currently running an image from an intermediate commit in our productive cluster and it works just fine.
GiteaMirror commented 2025-11-11 15:07:33 -06:00
Author
Owner
Copy Link
Copy Source

@tjbck commented on GitHub (Oct 25, 2024):

Seems to have been resolved, 0.3.34 will be released shortly! Thanks everyone!

@tjbck commented on GitHub (Oct 25, 2024): Seems to have been resolved, 0.3.34 will be released shortly! Thanks everyone!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#2449