github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #16670] [CLOSED] fix: [ISSUE-16669] Allow duplicate tool names across different servers #24204

New Issue
Closed
opened 2026-04-20 05:17:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 05:17:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16670
Author: @antondelgado123
Created: 8/16/2025
Status: ❌ Closed

Base: dev ← Head: ISSUE-16669-fix-duplicate-tool-names

📝 Commits (1)

  • b7aae1f [ISSUE-16669] Allow duplicate tool names across different servers

📊 Changes

1 file changed (+21 additions, -11 deletions)

View changed files

📝 backend/open_webui/utils/tools.py (+21 -11)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/issues/16669

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Fixes issue where tools with duplicate names across different MCP servers were silently removed, preventing users from utilizing multiple instances of the same tool type (e.g., multiple Clickhouse instances for EU and US). This enhancement allows LLMs to call duplicate tools on different servers, enabling cross-instance comparisons and operations.

Added

  • Support for duplicate tool names across different MCP server instances
  • Enhanced tool identification system to distinguish tools by server context

Changed

  • Modified tool registration logic to allow duplicate tool names from different servers by prefixing the Server name

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • Fixed silent removal of tools with duplicate names across different MCP servers (Issue #16669)
  • Resolved issue preventing LLMs from accessing multiple instances of the same tool type

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

  • Related Issue: Closes [GH-ISSUE #12650] feat: disable option for storing files when uploading for RAG (#16669)
  • Latest Commit: b7aae1fdcc303624efe8f7b656a458a40fa58ce6 - [ISSUE-16669] Allow duplicate tool names across different servers
  • Use Case: Enables scenarios like running multiple Clickhouse MCP instances (EU and US) and comparing query results across instances
  • Impact: Improves MCP functionality for users with multiple server instances of the same service type

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16670 **Author:** [@antondelgado123](https://github.com/antondelgado123) **Created:** 8/16/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `ISSUE-16669-fix-duplicate-tool-names` --- ### 📝 Commits (1) - [`b7aae1f`](https://github.com/open-webui/open-webui/commit/b7aae1fdcc303624efe8f7b656a458a40fa58ce6) [ISSUE-16669] Allow duplicate tool names across different servers ### 📊 Changes **1 file changed** (+21 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/tools.py` (+21 -11) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/issues/16669 **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixes issue where tools with duplicate names across different MCP servers were silently removed, preventing users from utilizing multiple instances of the same tool type (e.g., multiple Clickhouse instances for EU and US). This enhancement allows LLMs to call duplicate tools on different servers, enabling cross-instance comparisons and operations. ### Added - Support for duplicate tool names across different MCP server instances - Enhanced tool identification system to distinguish tools by server context ### Changed - Modified tool registration logic to allow duplicate tool names from different servers by prefixing the Server name ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - Fixed silent removal of tools with duplicate names across different MCP servers (Issue #16669) - Resolved issue preventing LLMs from accessing multiple instances of the same tool type ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - **Related Issue**: Closes #16669 - **Latest Commit**: `b7aae1fdcc303624efe8f7b656a458a40fa58ce6` - [ISSUE-16669] Allow duplicate tool names across different servers - **Use Case**: Enables scenarios like running multiple Clickhouse MCP instances (EU and US) and comparing query results across instances - **Impact**: Improves MCP functionality for users with multiple server instances of the same service type ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 05:17:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#24204
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?